Challenge can be reset with autorotate

[Cris-Edmundson]

Hi, thanks for the super helpful app!

I have auto rotate turned on on my phone, and if I turn my phone while showing plugbrain it refreshes the math problem I need to solve. If I've done the challenge multiple times and the math problem is really hard it seems like it resets the difficulty too

[Zephyr-Pixilated]

I've been looking at this issue. Not committed to it for now. Since this is an open source project, I've been reviewing the code with GeminiAI and reading documentation. It looks like we are using Koin as the dependency injection framework. I need to look at some tutorials on Koin. With Koin and Jetpack Compose, there are two options- the easy one- rememberSaveable and the more proper one would be to change the ModelView(ArithChallengeViewModel.kt). This project follows best practices, so I think you guys would prefer to change ModelView. It looks like that route would be making changes to ArithChallengeViewModel.kt and making data classes Parcelable in Challenge.kt and even making it a sealed interface, and even making all the challenges Parcelable? Am I on the right track with this? Were we also considering changing the architect in the future? What are your thoughts on it?

[Zephyr-Pixilated]

Awesome, thanks for the thumbs up. I"ll make a PR, and show you what changes I make. It will probably be done in a week or two. I need to study up on Koin and see how that all works.

[msbelaid]

@Zephyr-Pixilated, sorry for the late reply!

This part is a bit tricky because the challenge generation is triggered in onResume(), where we need to calculate the “free distraction duration” to adjust the difficulty dynamically (we always need a fresh instance of the challenge.)

As for Koin, the simplest fix would be to replace factory with single here
However, keep in mind that this will always return the same instance for each challenge type.

• factory → Creates a new instance every time it’s requested (each injection point gets a fresh object).
• single → Creates only one instance in the whole Koin container (all injections share the same instance).

Another quick fix would be to make the Challenge activity run only in portrait mode. What do you think?

[Cris-Edmundson]

As a not very technical person my first thought is to wonder if the challenge could be stored when generated and then the next time a challenge is generated, check if the existing stored challenge should be used (like if the challenge was just generated a moment ago, so maybe you could store a time stamp with the challenge) or if a new challenge should be made

That being said, I don't think portrait only is a bad solution in this case- typing on the number pad is an ideal ux when in portrait, so there would be other good reasons to just make that the normal behavior

Regardless of what y'all decide to do, thanks for all your hard work ☺️

[Zephyr-Pixilated]

@msbelaid Interesting. I like that approach. I thought any approach would require changes in the architecture.
@Cris-Edmundson I think that is a good idea. But the Android App and Koin have some built in stuff to handle this type of screen refresh. I think msbelaid and I are discussing what a bandaid fix would be, and what would be the proper way to fix it.

I am also working on another project. I'll show you guys on my profile what it is when I'm done. Someone can implement this bug fix. Or I can send a Pull Request within a couple of weeks.

[Zephyr-Pixilated]

Hello @msbelaid , I made the changes in a new branch here . With all due respect, I don't think it covers all use cases that could occur. I talked it over with Gemini, and I might want to implement the changes I talked about with changing the ModelView.

[msbelaid]

Thanks, @Zephyr-Pixilated, appreciate your effort.
As I mentioned earlier, the issue with using a single instead of a factory is that it creates a unique instance for each challenge, which prevents us from having variations.
That’s why I believe locking it to portrait mode is the best solution for now.

[Zephyr-Pixilated]

@msbelaid , that sounds good.