MUL-2375 fix(docker): pass VERSION, COMMIT, DATE build args to docker build#2715
Open
sapk wants to merge 3 commits into
Open
MUL-2375 fix(docker): pass VERSION, COMMIT, DATE build args to docker build#2715sapk wants to merge 3 commits into
sapk wants to merge 3 commits into
Conversation
Add build args to docker-compose.selfhost.build.yml so the Makefile variables (VERSION, COMMIT, DATE) are forwarded to the Docker build. Add ARG DATE=unknown to the Dockerfile and pass -X main.date= in the multica binary ldflags. This ensures docker-built binaries report proper version info instead of falling back to "dev".
|
@sapk is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
aj2666
approved these changes
May 19, 2026
433b48a to
097aaf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Forward Makefile build variables (VERSION, COMMIT, DATE) to Docker builds so that binaries inside Docker images report accurate version information instead of hardcoded defaults (dev/unknown).
Currently, docker-compose.selfhost.build.yml builds the backend image without passing any build args, so the resulting multica and server binaries fall back to version=dev and commit=unknown. The Makefile already computes these values from git metadata.
Add ARG DATE=unknown to the Dockerfile and pass -X main.date= in the multica binary ldflags similar to
make build.Related Issue
None
Type of Change
Changes Made
How to Test
Checklist
apps/web/features/landing/i18n/), starter-content (packages/views/onboarding/utils/starter-content-content-*.ts), and relevant docs (apps/docs/content/docs/)apps/docs/content/docs/developers/conventions.zh.mdx(terminology, mixed-rule fortask/issue/skill)AI Disclosure
AI tool used: Claude Code, Multica Agent
Prompt / approach:
Simply ask claude to create an issue in multica to fix version and pass already existing variable from Makefile to docker build.