Feature/jazzy#558
Open
mvukov wants to merge 57 commits into
Open
Conversation
Owner
Author
Contributor
|
I'm hitting but I'm not sure why yet.. Copilot says both the cpp_generator_aspect and c_generator_aspect are being applied to the same targets simultaneously, trying to write identical output files because we explicitly define interface libraries like this: I have doubts there, but it surely is related to the |
Contributor
|
here's another issue: |
Contributor
|
Something like this will work to fix the diff --git ros2/interfaces.bzl ros2/interfaces.bzl
index 1862319..f270df1 100644
--- ros2/interfaces.bzl
+++ ros2/interfaces.bzl
@@ -280,7 +280,7 @@ def run_generator(
generator_templates = generator_templates[DefaultInfo].files.to_list()
generator_arguments_file = ctx.actions.declare_file(
- "{}/{}_args.json".format(package_name, generator.basename),
+ "{}/{}{}_args.json".format(package_name, generator.basename, "_" + mnemonic if mnemonic else ""),
)
output_dir = generator_arguments_file.dirname
type_description_tuples = type_description.type_description_tuples if type_description != None else [] |
Contributor
|
here's the next issue: |
Owner
Author
|
I just expunged cache and |
Owner
Author
|
@lalten In case you have custom aspects that build on top of aspects from rules_ros2. Here's the new diagram: flowchart
idl_adapter_aspect --> type_description_aspect
type_description_aspect --> c_generator_aspect
c_generator_aspect --> cpp_generator_aspect
c_generator_aspect --> py_generator_aspect
i.e. there is a new aspect type_description_aspect that c-generator depends on. In addition cpp-codegen depends on c-codegen. Duplicates that could happen during codegen are fixed in repositories/patches/rosidl_fix_rosidl_typesupport_introspection_generator.patch and repositories/patches/rosidl_typesupport_generate_true_c_code.patch. |
Owner
Author
|
@lalten Any chance you'd have a bit more time sometime soon to take a look again at this PR? |
Contributor
Sorry, it's unlikely I'll find time until mid jan. I'd be ok with landing this and then figuring it out later :) |
lalten
reviewed
Mar 24, 2026
Contributor
There was a problem hiding this comment.
I think I got the Jazzy upgrade to work but I would need a bunch of changes in this (and ament.bzl) due to IDL support patches that we've not upstreamed yet.
@mvukov would it be possible to decouple these changes from the Jazzy upgrade and land them first?
Owner
Author
There was a problem hiding this comment.
Sure thing. I'm not in rush -- I'd just like to merge it sometime soon.
Contributor
|
I updated one repo to use this branch, things seem to be working fine. I think it'd be good to merge this to main and fix any issues that we may find later. Also I think maintaining Humble is dispensable. While it would be nice to have, it's probably not worth the effort. Providing a |
Contributor
|
Agree with ahans. Python 3.10 is starting to hold other things back for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.