Remove Python 3.13 from supported versions#599
Closed
lalten wants to merge 1 commit into
Closed
Conversation
Remove Python version 3.13 from the supported versions list.
Contributor
Author
|
Actually I'm now seeing issues in our build with this patch applied So this is also not a good solution... |
Contributor
Author
|
Another option would be to upgrade rules_ros2 to Numpy 2.
whl_filegroup(
name = "numpy_includes",
- pattern = "numpy/core/include/numpy",
+ pattern = "numpy/_core/include/numpy",
whl = "@rules_ros2_pip_deps//numpy:whl",
)
cc_library(
name = "rules_ros2_pip_deps_numpy_headers",
hdrs = [":numpy_includes"],
- includes = ["numpy_includes/numpy/core/include"],
+ includes = ["numpy_includes/numpy/_core/include"],
visibility = ["//visibility:public"],
deps = ["@rules_python//python/cc:current_py_cc_headers"],
)And drop Python 3.10 support (Numpy 2 has prebuilt wheels only for Python 3.11+) I'm not super sure about the implications of the Numpy ABI linkage that I mentioned. |
Contributor
Author
|
related: #424 |
Contributor
Author
|
Closing in favor of #600 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numpy 2.1.0 (https://numpy.org/devdocs/release/2.1.0-notes.html) is the first Numpy to support Python 3.13.
However ROS2 Humble requires Numpy <2. To my understanding this is mostly due to cv_bridge / OpenCV dependencies which are compiled against Numpy 1 ABI.
Numpy 1.x is also pinned in
rules_ros2/requirements.txt
Line 5 in 78d85ff
I'm trying to upgrade our Python interpreter to 3.13 currently and am running into an issue where some bazel query based checks choke on rules_ros2 failing to build a Numpy 2.3.5 from source due to bazel-contrib/rules_python#824
This is a simple fix for our queries.
I'm not really sure how Python 3.13 would work with ROS2 Humble (@mering vis / #474)
But hopefully we can get #558 at some point (promise to try it soon :D)