examples: Add image_pub_sub#629
Conversation
furushchev
force-pushed
the
image-transport-example-test
branch
2 times, most recently
from
5664ab8 to
9602c27
Compare
|
@mvukov I'm using the hermetic LLVM toolchain to build the libraries and it needs to add Q1: Is there any way to add test examples workspace with LLVM toolchain enabled in addition to the default GCC toolchain? |
Yup. |
mvukov
left a comment
mvukov
left a comment
There was a problem hiding this comment.
examples/image_pub_sub/image_pub_sub.test.py -> image_pub_sub_tests.py.
Per the Google style guide: C++ headers should have .h extension.
Nice work, I left some comments.
furushchev
force-pushed
the
image-transport-example-test
branch
from
9602c27 to
0c8b777
Compare
|
@mvukov Thanks for the review. I addressed things on your comments. |
mvukov
left a comment
mvukov
left a comment
There was a problem hiding this comment.
Left small comments to be addressed before the merge. Otherwise: LGTM, great job 🚀
| class RotatedPublisher final | ||
| : public image_transport::SimplePublisherPlugin<sensor_msgs::msg::Image> { | ||
| public: | ||
| virtual std::string getTransportName() const final { return "rotated"; } |
There was a problem hiding this comment.
Here and elsewhere, a small nit: IIRC, compilers are unlikely to optimize a virtual function from this header. Thus, those should be in the .cc file, same as publish.
| @@ -0,0 +1,163 @@ | |||
| #!/usr/bin/env python3 | |||
| # -*- coding: utf-8 -*- | |||
| # | |||
There was a problem hiding this comment.
Bazel doesn't need this and we don't use them in the repo. Please rm.
2 participants
Adds
examples/image_pub_subsubdirectory where example image transport plugins are registered and used for the test to verify the transport plugin works.With another test
ros2/test/image_common, it ensures the plugin mechanism works in downstream workspace.