cc_defs: Add -rdynamic to linkopts for clang compiler by default#631
Open
furushchev wants to merge 1 commit into
Open
cc_defs: Add -rdynamic to linkopts for clang compiler by default#631furushchev wants to merge 1 commit into
furushchev wants to merge 1 commit into
Conversation
Owner
|
Can we do this in a similar way as for clang? See https://github.com/mvukov/rules_ros2/blob/main/.bazelrc#L51-L53 -- we could have another llvm config there. |
Author
Hmm, this parameter is only necessary for binaries that link to the pluginlib library, so there's no need to set it globally. Therefore, I think it would be better to configure it in the current PR rather than writing it in |
Owner
|
This is llvm specific, so, I'd prefer to have this in an llvm config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #630
This change adds default linker option
-rdynamicto C++ binaries built withros2_cpp_binary.It's enabled only with LLVM toolchain (e.g. https://github.com/hermeticbuild/hermetic-llvm )