fix: Resolve runfiles in launch_exec templates#633
Open
furushchev wants to merge 2 commits into
Open
Conversation
mvukov
reviewed
May 25, 2026
mvukov
left a comment
mvukov
left a comment
Owner
There was a problem hiding this comment.
OK with me, left a few comments to be clarified before the merge.
| name = name, | ||
| srcs = [launcher], | ||
| data = [target_impl], | ||
| use_bash_launcher = True, |
Owner
There was a problem hiding this comment.
Does this mean that we had a bug before?
| @@ -1,5 +1,6 @@ | |||
| import os | |||
| import sys | |||
| from python.runfiles import runfiles | |||
Owner
There was a problem hiding this comment.
Please insert an empty line above as this is an external dep.
| fi | ||
| fi | ||
|
|
||
| ENTRYPOINT="$(rlocation {entry_point})" |
Owner
There was a problem hiding this comment.
Don't you have to depend on a target from rules_sh for this to work? I remember that earlier versions of rules_sh required copy/pasting of a snippet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation used
$(rootpath)to embed build-time paths to entry point executables. When launch wrappers were symlinked by other rules (such asbazel_env), these hardcoded paths became invalid, causing "file not found" errors at runtime.To fix the issue:
$(rootpath)with$(rlocationpath)in template substitutionslaunch_exec.sh.tpl: Userlocationfunctionlaunch_exec.py.tpl: Usepython.runfiles.Runfiles.Rlocationpy_binary/py_test: Add@rules_python//python/runfilesdependencysh_binary/sh_test: Enableuse_bash_launcher = Truefor rlocation support