Skip to content

duplicate check if contenthash is empty string causes unreachable code #46

@mendeleden

Description

@mendeleden

Lines 44-48 in set domain check if

  // Get content hash and encode it
  let contenthash = data.contenthash || null;
  let rawContenthash = contenthash;
  if (contenthash === "") {
    contenthash = null;
  }

If contenthash is an empty string, the first conditional yield null which means the conditional check later on is unused/does not cause any changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions