From 0337182d03fccf277f613d8995b6f57c542d7ffc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix=20Filmont?= Date: Tue, 1 Sep 2026 17:55:38 +0200 Subject: [PATCH 1/2] wip --- test/models/move_test.rb | 12 ------------ test/models/port_test.rb | 13 ------------- 2 files changed, 25 deletions(-) delete mode 100644 test/models/port_test.rb diff --git a/test/models/move_test.rb b/test/models/move_test.rb index d3932cc98..4c7ff6407 100644 --- a/test/models/move_test.rb +++ b/test/models/move_test.rb @@ -7,18 +7,6 @@ def setup @move = moves(:one) end - test "invalid without frame" do - @move.frame = nil - assert_not @move.valid?, "saved move without a frame" - assert_not_nil @move.errors[:frame], "no validation error for frame present" - end - - test "invalid without moveable object associated" do - @move.moveable = nil - assert_not @move.valid? - assert_not_nil @move.errors[:moveable] - end - test "clear current connections" do # Before @moved_connections = MovedConnection.per_servers([@move.moveable]) diff --git a/test/models/port_test.rb b/test/models/port_test.rb deleted file mode 100644 index 84f6d18b3..000000000 --- a/test/models/port_test.rb +++ /dev/null @@ -1,13 +0,0 @@ -# frozen_string_literal: true - -require File.expand_path("../test_helper", __dir__) - -class PortTest < ActiveSupport::TestCase - test "cable_color" do - assert_equal ports(:one).cable_color, "N" - end - - test "cable_name" do - assert_equal ports(:one).cable_name, "cableXYZ" - end -end From 565fff2a58e7d64a0e3889de6a833cc2dc9ccd5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix=20Filmont?= Date: Wed, 2 Sep 2026 12:17:55 +0200 Subject: [PATCH 2/2] convert server mini test to spec --- spec/models/server_spec.rb | 20 ++++++++++++++++++++ test/fixtures/modeles.yml | 2 +- test/models/server_test.rb | 33 --------------------------------- 3 files changed, 21 insertions(+), 34 deletions(-) delete mode 100644 test/models/server_test.rb diff --git a/spec/models/server_spec.rb b/spec/models/server_spec.rb index 9b5d1463d..18a70dc7c 100644 --- a/spec/models/server_spec.rb +++ b/spec/models/server_spec.rb @@ -162,6 +162,26 @@ pending end + describe "#documentation_url" do + context "with no documentation_url value on manufacturer" do + let(:server) { described_class.new({ numero: "some" }) } + + it { expect(server.documentation_url).to be_nil } + end + + context "with no numero on server" do + let(:server) { described_class.new({ modele_id: 1 }) } + + it { expect(server.documentation_url).to be_nil } + end + + context "with documentation_url value on manufacturer" do + let(:server) { servers(:one) } + + it { expect(server.documentation_url).to eq("https://fortinet.com/CZ31535FEY/document") } + end + end + describe "#deep_dup" do pending end diff --git a/test/fixtures/modeles.yml b/test/fixtures/modeles.yml index 281768a56..f4751fc4a 100644 --- a/test/fixtures/modeles.yml +++ b/test/fixtures/modeles.yml @@ -38,5 +38,5 @@ five: id: 5 name: PDU_25 architecture_id: 1 - manufacturer_id: 1 + manufacturer_id: 2 category_id: 3 diff --git a/test/models/server_test.rb b/test/models/server_test.rb deleted file mode 100644 index faecc5d9c..000000000 --- a/test/models/server_test.rb +++ /dev/null @@ -1,33 +0,0 @@ -# frozen_string_literal: true - -require File.expand_path("../test_helper", __dir__) - -class ServerTest < ActiveSupport::TestCase - test "scope only_pdus" do - assert_includes Server.only_pdus, servers(:pdu) - assert_not_includes Server.only_pdus, servers(:one) - end - - test "scope no_pdus" do - assert_not_includes Server.no_pdus, servers(:pdu) - assert_includes Server.no_pdus, servers(:one) - end - - test "#documentation_url with no documentation_url value on manufacturer" do - server = servers(:pdu) - server.numero = nil - - assert_nil server.documentation_url - end - - test "#documentation_url with no numero value on manufacturer" do - server = servers(:one) - server.numero = nil - - assert_nil server.documentation_url - end - - test "#documentation_url with documentation_url value on manufacturer" do - assert servers(:one).documentation_url == "https://fortinet.com/CZ31535FEY/document" - end -end