Skip to content

From impl in inline_str.rs is not infallible #5

Description

@nberlette

Per the Rust documentation, From impls should never fail. However, in at least 1 location there is a From impl that will panic if the string being converted exceeds the maximum inline string length.

This crate needs a thorough review of all impls to identify problems like this, and then they need to be addressed and fixed (or the offending impl removed if it cannot be made compliant with Rust standards).

This is a tracking issue for a PR that I'll create whenever I have the time. If @copilot can handle this task and produce satisfactory results, I may delegate this to it instead, given how little time I have these days.

Regards,
Nick

Metadata

Metadata

Labels

bugSomething isn't workinghelp wantedExtra attention is needed

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions