Check consistency of dataset, environment variables, and code

[Robin-Wardle]

Sources of input data for the FIRM2 model are defined / present in:

• variables defaults in model-parameters.yml, which are definable by the user in the DAFNI interface
• variables fallbacks in .firm2.properties
• /data/inputs

The definitions of the sources and the names of the sources should be checked for consistency. E.g. there's a Roads.json file and a BNG_roads.json file in the dataset that will end up in /data/inputs, but the model-definition.yml referred to roads.json (this has been changed). The timeline.json file is not listed in model-definition.yml.

[Robin-Wardle]

@jsteyn I think this is all sorted now, can you review and close if yes?

[Robin-Wardle]

@jsteyn

The following still exist in /data/inputs:

• Roads.json
• timeline1.json

i don't think these are referenced anywhere. These files don't exist in the Towyn example data set on DAFNI. Should they be deleted?

the files businesstypes.json, codes.json and buildingtypes.json are not referenced in model_definition.yml but I presume these are used internally by the simulator? These files do exist in the Towyn example data set.