From 0a7a36c300443ec9500bd9b2fe0af20686b82263 Mon Sep 17 00:00:00 2001 From: Michael Bianco Date: Thu, 19 May 2016 17:16:15 -0400 Subject: [PATCH 1/2] Log payloads that are skipped becuse no jobs were run --- app/interactors/cangaroo/perform_jobs.rb | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/app/interactors/cangaroo/perform_jobs.rb b/app/interactors/cangaroo/perform_jobs.rb index 972db2f..d39b654 100644 --- a/app/interactors/cangaroo/perform_jobs.rb +++ b/app/interactors/cangaroo/perform_jobs.rb @@ -1,5 +1,6 @@ module Cangaroo class PerformJobs + include Cangaroo::Log include Interactor def call @@ -15,7 +16,18 @@ def data end def enqueue_jobs(type, payload) - initialize_jobs(type, payload).select(&:perform?).each(&:enqueue) + initialize_jobs(type, payload).each do |job| + if job.perform? + # TODO log simplified info about payload info is being queued + job.enqueue + else + # TODO persist translation for audit trail? + + log.info 'skipping payload, no jobs', + payload: payload, + payload_type: type + end + end end def initialize_jobs(type, payload) From 1fb090a6e15d18845242c80b4b7cff854f68d5a0 Mon Sep 17 00:00:00 2001 From: Michael Bianco Date: Tue, 7 Jun 2016 21:26:22 -0400 Subject: [PATCH 2/2] Log payload state and job class when job is skipped --- app/interactors/cangaroo/perform_jobs.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/interactors/cangaroo/perform_jobs.rb b/app/interactors/cangaroo/perform_jobs.rb index d39b654..34b24b0 100644 --- a/app/interactors/cangaroo/perform_jobs.rb +++ b/app/interactors/cangaroo/perform_jobs.rb @@ -23,9 +23,11 @@ def enqueue_jobs(type, payload) else # TODO persist translation for audit trail? - log.info 'skipping payload, no jobs', + log.info 'skipping job for payload', + skipped_job: job.class.to_s, payload: payload, - payload_type: type + payload_type: type, + payload_state: job.payload_state end end end