Refactor: remove Profile intermediate entity from Deal — move criteria joins directly onto Deal

[nadavosa]

Background

The current model has a Profile entity sitting between Deal and the actual criteria objects:

Deal → Profile → ProfileActivity → Activity
                → ProfileLanguage → Language
                → ProfileSkill   → Skill
                → Category (optional)
                .info (optional string)

Both Opportunity and Volunteer inherit their shared criteria (languages, activities, skills) by navigating entity.deal.profile.*. The Profile entity was likely introduced to allow criteria reuse across multiple Deals (the schema allows one Profile to be referenced by many Deals), but in practice each Deal appears to have its own Profile — making it over-engineered.

Proposed Change

Remove Profile and collapse its M2M relationships directly onto Deal:

Deal → DealActivity → Activity
     → DealLanguage → Language
     → DealSkill    → Skill

The profile.info and profile.category fields would need a new home — likely directly on Deal, or split to Opportunity / Volunteer depending on which actually uses them.

Impact Areas to Audit Before Making Changes

Before touching any code, the following must be scanned:

• All services/repositories that query or write deal.profile (profile loading, eager joins)
• All DTOs / response types that expose profile fields in API responses
• All controller endpoints that accept or return profile-shaped data
• FE API calls and types that reference profile — see https://github.com/need4deed-org/fe
• Any seed data or fixtures that create Profile records
• Migrations — new join tables (deal_activity, deal_language, deal_skill) must be created and old profile_activity, profile_language, profile_skill data migrated before dropping profile
• The category relationship currently on Profile — decide where it moves
• The profile.info field — decide where it moves

Acceptance Criteria

• Profile, ProfileActivity, ProfileLanguage, ProfileSkill entities are removed
• Deal directly exposes activity, language, and skill M2M relationships
• All existing data is migrated without data loss
• No API response shape changes that break the FE without a coordinated FE update
• All tests pass

Notes

• This is a breaking change to the API response shape — coordinate with the FE team before merging
• Do NOT add migration columns/tables until the approach above is agreed upon

[nadavosa]

Audit Results

Full codebase scan completed. Here is the complete impact analysis.

---

Summary

25 files affected · ~100 code references · 1 database migration required · Estimated effort: 12–15 hours

profile.info and profile.categoryId are actively used (seeds + DTOs + category handler) — they must move to Deal, not be dropped.

---

Entities

Delete (4 files):

• src/data/entity/profile/profile.entity.ts
• src/data/entity/m2m/profile-activity.ts
• src/data/entity/m2m/profile-language.ts
• src/data/entity/m2m/profile-skill.ts

Create (3 files):

• src/data/entity/m2m/deal-activity.ts — copy of profile-activity, replace Profile→Deal, profile_id→deal_id
• src/data/entity/m2m/deal-language.ts — same, preserve proficiency and purpose enum columns
• src/data/entity/m2m/deal-skill.ts — copy of profile-skill

Modify deal.entity.ts:

• Remove @ManyToOne(() => Profile) + profileId
• Add info?: string, categoryId?: number, @ManyToOne(() => Category) category
• Add three @OneToMany() to DealActivity / DealLanguage / DealSkill

Also update OneToMany back-references in: activity.entity.ts, language.entity.ts, skill.entity.ts, category.entity.ts

---

Services / DTOs

File	What changes
src/services/dto/parser-deal-volunteer.ts	Creates Profile + assigns to Deal — rewrite to build DealActivity/Language/Skill arrays on Deal directly
src/services/dto/parser-deal-opportunity.ts	Same pattern as above
src/services/dto/dto-opportunity.ts	6 reads of deal.profile.* — replace with deal.*
src/services/dto/dto-volunteer.ts	3 reads of deal.profile.* — replace with deal.*

---

Routes / Utilities

File	What changes
src/server/routes/opportunity/opportunity.routes.ts	3 eager-load relation paths through profile
src/server/routes/opportunity/legacy.routes.ts	Reads deal.profile object + 3 relation paths
src/server/routes/volunteer/volunteer.routes.ts	3 relation paths
src/server/utils/data/write-volunteer-legacy.ts	Saves Profile separately, assigns profileId to M2M — remove separate save, use dealId
src/server/utils/data/write-opportunity-legacy.ts	Same pattern
src/server/utils/data/serve-volunteer-list.ts	Complex query builder with nested profile joins
src/server/utils/data/for-routes.ts	Direct property access on profile
src/server/utils/data/add-category-to-profile.ts	Rename to add-category-to-deal.ts, update all logic

---

Infrastructure

File	What changes
src/data/data-source.ts	Remove Profile / ProfileActivity / ProfileLanguage / ProfileSkill from entities array
src/server/plugins/typeorm.ts	Remove profileRepository export
src/server/types/fastify.d.ts	Remove Profile type references
src/data/seeds/utils.ts	dealData.profile.info (line 345) and profile.categoryId (line 389) — write directly to Deal

---

Tests

File	What changes
src/test/server/utils/write-volunteer.test.ts	Mocks all four Profile entities — update all mock mappings
src/test/server/utils/data/add-category-to-profile.test.ts	Rename to add-category-to-deal.test.ts, refactor

---

Database Migration

Single migration file must:

1. Add info and category_id columns to deal
2. Create deal_activity, deal_language (with proficiency/purpose enums), deal_skill tables
3. Migrate data from profile_* tables → deal_* tables (join via profile.deal_id)
4. Migrate profile.info and profile.category_id → deal
5. Drop profile_activity, profile_language, profile_skill, profile tables

---

Breaking Change Warning

This changes the API response shape wherever profile is currently a nested object in opportunity/volunteer responses. The FE must update its types and API calls in the same release — coordinate with https://github.com/need4deed-org/fe before merging.