diff --git a/.github/workflows/run-e2e-tests.yaml b/.github/workflows/run-e2e-tests.yaml index 64bc02c..fc2c0c4 100644 --- a/.github/workflows/run-e2e-tests.yaml +++ b/.github/workflows/run-e2e-tests.yaml @@ -1,15 +1,13 @@ name: E2E Test Workflow on: - pull_request_review: - types: - - submitted - schedule: - - cron: '0 0 1 * *' + pull_request: + branches: + - develop + - main jobs: build-templates: - if: github.event.review.state == 'approved' runs-on: ubuntu-latest permissions: id-token: write @@ -49,14 +47,6 @@ jobs: name: ${{ matrix.TEMPLATE_FILE }}.yaml path: .aws-sam/build/${{ matrix.TEMPLATE_FILE }}/${{ matrix.TEMPLATE_FILE }}.yaml - - name: Send failure notification to Slack - if: always() - uses: ravsamhq/notify-slack-action@v1 - with: - status: ${{ job.status }} - notify_when: 'failure' - env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} run-e2e-tests-cloudwatch: needs: [build-templates] @@ -99,14 +89,6 @@ jobs: cd e2e-tests ./lambda-cloudwatch-trigger.sh ${{ matrix.test-case }} - - name: Send failure notification to Slack - if: always() - uses: ravsamhq/notify-slack-action@v1 - with: - status: ${{ job.status }} - notify_when: 'failure' - env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} run-e2e-tests-s3: needs: [build-templates] @@ -149,15 +131,6 @@ jobs: cd e2e-tests ./lambda-s3-trigger.sh ${{ matrix.test-case }} - - name: Send failure notification to Slack - if: always() - uses: ravsamhq/notify-slack-action@v1 - with: - status: ${{ job.status }} - notify_when: 'failure' - env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} - run-e2e-tests-lambda-firehose-metrics: needs: [build-templates] runs-on: ubuntu-latest @@ -199,15 +172,6 @@ jobs: cd e2e-tests/ ./lambda-with-metrics-test.sh ${{ matrix.test-case }} - - name: Send failure notification to Slack - if: always() - uses: ravsamhq/notify-slack-action@v1 - with: - status: ${{ job.status }} - notify_when: 'failure' - env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} - clean-up: needs: [run-e2e-tests-cloudwatch, run-e2e-tests-s3, run-e2e-tests-lambda-firehose-metrics] runs-on: ubuntu-latest @@ -230,12 +194,3 @@ jobs: S3_BUCKET: unified-lambda-e2e-test-templates run: aws s3 rm "s3://$S3_BUCKET" --recursive - - - name: Send failure notification to Slack - if: always() - uses: ravsamhq/notify-slack-action@v1 - with: - status: ${{ job.status }} - notify_when: 'failure' - env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} \ No newline at end of file diff --git a/e2e-tests/lambda-cloudwatch-trigger.sh b/e2e-tests/lambda-cloudwatch-trigger.sh index 2e81f99..fb7e3fa 100755 --- a/e2e-tests/lambda-cloudwatch-trigger.sh +++ b/e2e-tests/lambda-cloudwatch-trigger.sh @@ -18,21 +18,6 @@ COMMON_ATTRIBUTES=$( s3-parameter.json EOF S3_BUCKET_NAMES=$(