fix: write updater JSON with tabs to match repo style#89
Merged
Conversation
jq defaults to two-space indentation, so the generated config/releases.json and config/major_versions.json in the updater_server PR came out space-indented while the repo uses tabs - producing a noisy, whole-file reindent diff. Pass --tab to the jq calls that write those files. Regenerate the updater test snapshots accordingly (they now match the tab-indented base fixture). Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The updater_server PRs (e.g. nextcloud-releases/updater_server#1380) reindented
config/releases.jsonfrom tabs to 2 spaces —jqdefaults to 2-space output, andupdate-updater-server.shrewrites the whole file withjq. Result: a noisy whole-file diff and a style mismatch (the repo uses tabs).Fix
Add
--tabto thejqcalls that writeconfig/releases.jsonandconfig/major_versions.json. Output now matches the tab-indented source.Updater test snapshots regenerated (they already used a tab-indented base fixture; the expected files were the only thing carrying the 2-space output).
Testing
bash tests/updater-script/run.sh→ 8/8 passexpected/config/releases.jsonare tab-indented