fix(print): ensure all images are loaded before opening print dialog#2562
Open
mejo- wants to merge 3 commits into
Open
fix(print): ensure all images are loaded before opening print dialog#2562mejo- wants to merge 3 commits into
mejo- wants to merge 3 commits into
Conversation
Fixes: #2553 Pass `noLazyImages` to createEditor when loading reader in print view, so images are fetched straight away and not lazy-loaded. Requires nextcloud/text#8719 Also await Text's `onLoaded` callback in setupReader to await the async component loading of MarkdownContentEditor. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
Signed-off-by: Jonas <jonas@freesources.org>
Member
Author
|
The new Playwright test will only succeed after nextcloud/text#8719 (and the corresponding backport PRs) got merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2553
Pass
noLazyImagesto createEditor when loading reader in print view, so images are fetched straight away and not lazy-loaded.Requires nextcloud/text#8719
Also await Text's
onLoadedcallback in setupReader to await the async component loading of MarkdownContentEditor.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)