Only update profile pictures from social media if it has actually changed

[schneidr]

Is your feature request related to a problem? Please describe.

When using shared address books the people get "contact has been updated" every week in the activity feed. This should not happen if the picture hasn't even changed.

Describe the solution you'd like

Only update the contact if the avatar picture of the social media account has actually been changed.

Describe alternatives you've considered

I can't think of any alternative.

Additional context

No response

[DerDreschner]

Hey @schneidr, thanks for your report! Could you please share the system configuration, installed app as well as some log files from the time the message appears with me? Because I can't reproduce the issue in our use-cases right now. Thanks!!

sudo -u www-data php occ config:list system
php occ config:list system
./occ config:list system

and

sudo -u www-data php occ app:list
php occ app:list
./occ app:list

[schneidr]

I'm using the official docker

occ config:list system

{
    "system": {
        "htaccess.RewriteBase": "\/",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "upgrade.disable-web": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "password": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "nextcloud.example.com"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "33.0.2.2",
        "overwrite.cli.url": "https:\/\/nextcloud.example.com\/",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "maintenance": false,
        "memories.db.triggers.fcu": true,
        "memories.exiftool": "\/var\/www\/html\/custom_apps\/memories\/bin-ext\/exiftool-amd64-glibc",
        "memories.vod.path": "\/var\/www\/html\/custom_apps\/memories\/bin-ext\/go-vod-amd64",
        "preview_max_x": 2048,
        "preview_max_y": 2048,
        "enabledPreviewProviders": [
            "OC\\Preview\\TXT",
            "OC\\Preview\\MarkDown",
            "OC\\Preview\\OpenDocument",
            "OC\\Preview\\Krita",
            "OC\\Preview\\Imaginary",
            "OC\\Preview\\ImaginaryPDF",
            "OC\\Preview\\MSOfficeDoc",
            "OC\\Preview\\MP3",
            "OC\\Preview\\MP4",
            "OC\\Preview\\AVI",
            "OC\\Preview\\Movie",
            "OC\\Preview\\MKV",
            "OC\\Preview\\XCF"
        ],
        "memories.gis_type": 1,
        "overwritehost": "nextcloud.example.com",
        "overwriteprotocol": "https",
        "overwritewebroot": "\/",
        "app_install_overwrite": [
            "maps"
        ],
        "mail_smtpmode": "smtp",
        "mail_smtpauth": true,
        "mail_sendmailmode": "smtp",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "default_phone_region": "DE",
        "maintenance_window_start": 1,
        "preview_imaginary_url": "***REMOVED SENSITIVE VALUE***",
        "loglevel": 1
    }
}

php occ app:list

Enabled:
  - activity: 6.0.0
  - bruteforcesettings: 6.0.0
  - cloud_federation_api: 1.17.0
  - dashboard: 7.13.0
  - dav: 1.36.0
  - federatedfilesharing: 1.23.0
  - federation: 1.23.0
  - files: 2.5.0
  - files_downloadlimit: 5.1.0
  - files_external: 1.25.1
  - files_pdfviewer: 6.0.0
  - files_reminders: 1.6.0
  - files_sharing: 1.25.2
  - files_trashbin: 1.23.0
  - files_versions: 1.26.0
  - firstrunwizard: 6.0.0
  - logreader: 6.0.0
  - lookup_server_connector: 1.21.0
  - nextcloud_announcements: 5.0.0
  - notifications: 6.0.0
  - oauth2: 1.21.0
  - password_policy: 5.0.0
  - privacy: 5.0.0
  - profile: 1.2.0
  - provisioning_api: 1.23.0
  - recommendations: 6.0.0
  - related_resources: 4.0.0
  - serverinfo: 5.0.0
  - settings: 1.16.0
  - sharebymail: 1.23.0
  - support: 5.0.0
  - systemtags: 1.23.0
  - text: 7.0.0
  - theming: 2.8.0
  - twofactor_backupcodes: 1.22.0
  - twofactor_totp: 15.0.0
  - updatenotification: 1.23.0
  - user_status: 1.13.0
  - viewer: 6.0.0
  - weather_status: 1.13.0
  - webhook_listeners: 1.5.0
  - whiteboard: 1.5.7
  - workflowengine: 2.15.0
Disabled:
  - admin_audit: 1.23.0
  - app_api: 33.0.0 (installed 32.0.0)
  - circles: 33.0.0 (installed 33.0.0)
  - comments: 1.23.0 (installed 1.23.0)
  - contactsinteraction: 1.14.1 (installed 1.13.1)
  - encryption: 2.21.0
  - maps: 1.6.0 (installed 1.6.0)
  - photos: 6.0.0 (installed 5.0.0-dev.1)
  - previewgenerator: 5.13.0 (installed 5.13.0)
  - survey_client: 5.0.0 (installed 5.0.0)
  - suspicious_login: 11.0.0
  - testing: 1.23.0
  - twofactor_nextcloud_notification: 7.0.0
  - user_ldap: 1.24.0

If helpful: This is my docker-compose.yml

volumes:
  db:

services:
  db:
    image: mariadb:10.11
    command: --transaction-isolation=READ-COMMITTED --binlog-format=ROW
    restart: unless-stopped
    volumes:
      - db:/var/lib/mysql
    env_file:
      - nextcloud.env

  app:
    image: nextcloud
    ports:
      - 127.0.0.1:8080:80
      - '[::1]:8080:80'
    links:
      - db
      - redis
    volumes:
      - ${BASEDIR_DATA}/nextcloud:/var/www/html
      - ${USER_HOMES}:/home
      - /docker/nextcloud/before-starting.sh:/docker-entrypoint-hooks.d/before-starting/before-starting.sh
      - type: tmpfs
        target: /tmp:exec
    env_file:
      - nextcloud.env
    restart: unless-stopped

  redis:
    image: redis:alpine
    restart: unless-stopped
    command: redis-server --requirepass ${REDIS_HOST_PASSWORD}
    env_file:
      - nextcloud.env

I can't find any related entries in the Nextcloud logs.

[DerDreschner]

@schneidr Thanks for the info! I'll see if I can replicate the issue

[DerDreschner]

@schneidr I can see what happens there! We'll have a look if we can fix it soon. Thanks for your report!