From 5c0e7ae9c7d327448103ecfa1a4a35dddd2fc965 Mon Sep 17 00:00:00 2001
From: Anna Larch <anna@nextcloud.com>
Date: Tue, 26 May 2026 23:26:02 +0200
Subject: [PATCH] test(share20): replace addToAssertionCount checkbox tests in
 Share20 ManagerTest

Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 tests/lib/Share20/ManagerTest.php | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/tests/lib/Share20/ManagerTest.php b/tests/lib/Share20/ManagerTest.php
index 059b7a4df3a71..21098e7f38af9 100644
--- a/tests/lib/Share20/ManagerTest.php
+++ b/tests/lib/Share20/ManagerTest.php
@@ -2059,7 +2059,6 @@ public function testUserCreateChecksShareWithGroupMembersOnlySharedGroup(): void
 			->willReturn([]);
 
 		self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
 	}
 
 
@@ -2203,7 +2202,6 @@ public function testUserCreateChecksIdenticalPathNotSharedWithUser(): void {
 			->willReturn([$share2]);
 
 		self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
 	}
 
 
@@ -2301,7 +2299,6 @@ public function testGroupCreateChecksShareWithGroupMembersOnlyInGroup(): void {
 			]);
 
 		self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
 	}
 
 
@@ -2357,7 +2354,6 @@ public function testGroupCreateChecksPathAlreadySharedWithDifferentGroup(): void
 			]);
 
 		self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
 	}
 
 
@@ -2377,6 +2373,7 @@ public function testLinkCreateChecksNoLinkSharesAllowed(): void {
 	}
 
 
+	#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
 	public function testFileLinkCreateChecksNoPublicUpload(): void {
 		$share = $this->manager->newShare();
 
@@ -2391,7 +2388,6 @@ public function testFileLinkCreateChecksNoPublicUpload(): void {
 			]);
 
 		self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
 	}
 
 	public function testFolderLinkCreateChecksNoPublicUpload(): void {
@@ -2413,6 +2409,7 @@ public function testFolderLinkCreateChecksNoPublicUpload(): void {
 		self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
 	}
 
+	#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
 	public function testLinkCreateChecksPublicUpload(): void {
 		$share = $this->manager->newShare();
 
@@ -2429,9 +2426,9 @@ public function testLinkCreateChecksPublicUpload(): void {
 			]);
 
 		self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
 	}
 
+	#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
 	public function testLinkCreateChecksReadOnly(): void {
 		$share = $this->manager->newShare();
 
@@ -2448,7 +2445,6 @@ public function testLinkCreateChecksReadOnly(): void {
 			]);
 
 		self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
-		$this->addToAssertionCount(1);
 	}
 
 
@@ -2481,14 +2477,13 @@ public function testPathCreateChecksContainsNoSharedMount(): void {
 		$this->mountManager->method('findIn')->with('path')->willReturn([$mount]);
 
 		self::invokePrivate($this->manager, 'pathCreateChecks', [$path]);
-		$this->addToAssertionCount(1);
 	}
 
+	#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
 	public function testPathCreateChecksContainsNoFolder(): void {
 		$path = $this->createMock(File::class);
 
 		self::invokePrivate($this->manager, 'pathCreateChecks', [$path]);
-		$this->addToAssertionCount(1);
 	}
 
 	public static function dataIsSharingDisabledForUser() {
@@ -4689,7 +4684,6 @@ public function testMoveShareUser(): void {
 		$this->defaultProvider->method('move')->with($share, 'recipient')->willReturnArgument(0);
 
 		$this->manager->moveShare($share, 'recipient');
-		$this->addToAssertionCount(1);
 	}
 
 
@@ -4747,7 +4741,6 @@ public function testMoveShareGroup(): void {
 		$this->defaultProvider->method('move')->with($share, 'recipient')->willReturnArgument(0);
 
 		$this->manager->moveShare($share, 'recipient');
-		$this->addToAssertionCount(1);
 	}
 
 	#[DataProvider('dataTestShareProviderExists')]