From 24631d900ce47d45b80a45c4623dae5897a51a60 Mon Sep 17 00:00:00 2001 From: Josh Date: Wed, 27 May 2026 17:06:45 -0400 Subject: [PATCH 1/3] fix(Storage): use proxyexclude parameter in DAV client Signed-off-by: Josh --- lib/private/Files/Storage/DAV.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/private/Files/Storage/DAV.php b/lib/private/Files/Storage/DAV.php index 0c74abdfee1a2..c62b1136cd599 100644 --- a/lib/private/Files/Storage/DAV.php +++ b/lib/private/Files/Storage/DAV.php @@ -159,6 +159,11 @@ protected function init(): void { $this->client = new Client($settings); $this->client->setThrowExceptions(true); + $proxyExclude = Server::get(IConfig::class)->getSystemValue('proxyexclude', []); + if (!empty($proxyExclude)) { + $this->client->addCurlSetting(CURLOPT_NOPROXY, implode(',', $proxyExclude)); + } + if ($this->secure === true) { if ($this->verify === false) { $this->client->addCurlSetting(CURLOPT_SSL_VERIFYPEER, false); From 216b8dc11e411d1586fbf58b09d2b9d51e2cb6c5 Mon Sep 17 00:00:00 2001 From: Josh Date: Wed, 27 May 2026 17:25:58 -0400 Subject: [PATCH 2/3] chore(DAV): fixup for lint Signed-off-by: Josh --- lib/private/Files/Storage/DAV.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/private/Files/Storage/DAV.php b/lib/private/Files/Storage/DAV.php index c62b1136cd599..db6371b2c7ea4 100644 --- a/lib/private/Files/Storage/DAV.php +++ b/lib/private/Files/Storage/DAV.php @@ -161,7 +161,7 @@ protected function init(): void { $proxyExclude = Server::get(IConfig::class)->getSystemValue('proxyexclude', []); if (!empty($proxyExclude)) { - $this->client->addCurlSetting(CURLOPT_NOPROXY, implode(',', $proxyExclude)); + $this->client->addCurlSetting(CURLOPT_NOPROXY, implode(',', $proxyExclude)); } if ($this->secure === true) { From 37c8937c87c52f85607232ff8b51d17d73a59b3a Mon Sep 17 00:00:00 2001 From: Josh Date: Thu, 28 May 2026 13:10:56 -0400 Subject: [PATCH 3/3] chore(DAV): fixup proxyexclude default value check Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Josh --- lib/private/Files/Storage/DAV.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/private/Files/Storage/DAV.php b/lib/private/Files/Storage/DAV.php index db6371b2c7ea4..b6e4a44f64b22 100644 --- a/lib/private/Files/Storage/DAV.php +++ b/lib/private/Files/Storage/DAV.php @@ -160,7 +160,7 @@ protected function init(): void { $this->client->setThrowExceptions(true); $proxyExclude = Server::get(IConfig::class)->getSystemValue('proxyexclude', []); - if (!empty($proxyExclude)) { + if ($proxyExclude !== []) { $this->client->addCurlSetting(CURLOPT_NOPROXY, implode(',', $proxyExclude)); }