Skip to content

fix(translate): use assistant app dialog#8628

Merged
mejo- merged 1 commit into
mainfrom
fix/assistant_translate_dialog
May 21, 2026
Merged

fix(translate): use assistant app dialog#8628
mejo- merged 1 commit into
mainfrom
fix/assistant_translate_dialog

Conversation

@mejo-

@mejo- mejo- commented May 20, 2026

Copy link
Copy Markdown
Member

No need for a custom translate dialog these days given that the assistant app provides one.

Fixes: #8036

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

  • The content of this PR was partly generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@mejo- mejo- self-assigned this May 20, 2026
@mejo- mejo- added bug Something isn't working 3. to review labels May 20, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team May 20, 2026
No need for a custom translate dialog these days given that the
assistant app provides one.

Fixes: #8036

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/assistant_translate_dialog branch from 35449b0 to ea4fce3 Compare May 20, 2026 17:04
@mejo- mejo- requested a review from samin-z May 20, 2026 17:04
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team May 20, 2026
@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/Menu/AssistantAction.vue 0.00% 19 Missing and 5 partials ⚠️

📢 Thoughts on this report? Let us know!

@mejo-

mejo- commented May 20, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@mejo- mejo- merged commit b99fb64 into main May 21, 2026
73 of 76 checks passed
@mejo- mejo- deleted the fix/assistant_translate_dialog branch May 21, 2026 07:26
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team May 21, 2026
@nextcloud nextcloud deleted a comment from backportbot Bot May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Translate dialog fixes

2 participants