File dialog crash on Wayland (Fedora 43) - NFD_GetNativeWindowFromGLFWWindow fails

[scroyroyo]

Description

ngscopeclient crashes when opening any file save/open dialog on Wayland.

Environment

• OS: Fedora 43 (Wayland session, KDE Plasma)
• Desktop portals installed: xdg-desktop-portal, xdg-desktop-portal-gtk, xdg-desktop-portal-kde

Steps to Reproduce

1. Launch ngscopeclient on Wayland
2. Try to open any file dialog (File → Save, Export, etc.)
3. Crash occurs

Error Output

ERROR: failed to get window handle
(ngscopeclient:PID): Gtk-CRITICAL **: gtk_widget_get_window: assertion 'GTK_IS_WIDGET (widget)' failed
Segmentation fault (core dumped)

Backtrace

Crash occurs in GTK widget sizing code after NFD_GetNativeWindowFromGLFWWindow() fails to get a valid window handle on Wayland.

Workarounds Attempted

• GTK_USE_PORTAL=0 - still crashes
• GTK_THEME=Adwaita - still crashes
• GDK_BACKEND=x11 - still crashes

Analysis

The issue appears to be in NFDFileBrowser.cpp:141-142 where NFD_GetNativeWindowFromGLFWWindow() fails on Wayland. The code continues with an invalid parent window handle, causing the subsequent GTK dialog to crash.

Possible Fix

NFD library may need updates for proper Wayland support, or the file dialog code needs a fallback when the native window handle cannot be obtained.

[azonenberg]

I'll look into this.

Since NFD has had issues on other platforms (most notably macos) we do have a non-native ImGui based file dialog that you can use as a fallback, accessible under the preferences dialog. This should at least get you up and running with ngscopeclient at the cost of a more awkward file load/save experience.