Question about testing conda installation

[cmbarton]

Hi Nicklas,

I'm happy to test this out but am not sure exactly how to do it, as it does not seem to be (yet) a normal conda install. Also, I don't want to mess up my current GRASS source git folder if I can avoid it (not a big deal). Can you give a bit more details on the work flow? Thanks

[nilason]

I'm know I have been short on description (intend to work on that).

I'm using, as far as I know, a perfectly normal (default) anaconda installation. So that shouldn't be an issue.
If you checkout e.g master or releasebranch_7_8, with no other alterations (that you wish to keep), the instructions on Readme will restore to original state. If you really want to play safe (not really needed) you can always branch before.

The script assumes anaconda is located in ~/opt/anaconda3. If this isn't the case for you, then the script has to be modified. Other than that, it should be safe. I put as many safety check as I could – so not much can go wrong (only fail).

This script package does all (almost) of the steps you wrote in grasswiki: patches, installs miniconda, compiles and installs.

If you already have a /Applications/GRASS-7.X.app that you wish to keep, please temporarily rename it (there is a check for this too).

Make sure to cd to the script directory (grass-conda), and fill in your configs in configure-build.sh and execute ./build-grass.sh.

[nilason]

I made a major update, use current repo state in case of testing.

See also the updated Readme.

One notable difference is that the patched files are automatically reverted when finished or in case of failure: no need to worry about that.

I also did a restructuring of the main script file ./build-grass.sh, which now is better self-explanatory if you wish to review the code.
Additionally, the ~/opt/anaconda3 issue should be any problem.

PS. I also successfully tested building with SDK 10.13!

[nilason]

Beware, the patches are updated for – and only works for – 7.9.dev at present.

Looking for a more general solution...

[nilason]

Beware, the patches are updated for – and only works for – 7.9.dev at present.

Looking for a more general solution...

This is now fixed. Current repo state handles 7.8.3, 7.8.4dev and 7.8.9dev.

[nilason]

@cmbarton, I have updated again. Now it is also possible to create dmg file, see updated readme.

[cmbarton]

This is very exciting @nilason. I hope to be able to try it out soon, once I have other obligations out of the way

[nilason]

This is very exciting @nilason. I hope to be able to try it out soon, once I have other obligations out of the way

It is exciting! As it is a work-in-progress, I only want you to be informed for the moment when you'll have the time...

[cmbarton]

This week is pretty crazy, but maybe I'll be able to run some tests.

Just to make sure I understand, to compile this into a binary as I have been doing previously, I simply need to update to the newest versions of 7.9 and 7.8.4, apply your new patches, and compile. Right?

I will set configure to look for the current Mac SDK. Do you have a way to test whether this runs on Mojave? My computers are all at Catalina.

If that goes OK, I'll venture out to try your Anaconda recipe. Thanks again for all your work on this.

[nilason]

The script will do all the steps you described in grasswiki, including patching.
To build and install you need to configure:

• SDK full path to the SDK that will be set to -isysroot, this is what will be used on building, you may preferably use one older one for broader support (e.g. 10.12 or 10.13) I tried successfully with 10.13.
• GRASSDIR full path to the GRASS GIS source directory
• CONDA_ENV name of conda environment

Regardless which SDK you use in compiling, the script will change the path to sysroot in Platform.make after installation to a hardlinked (but non-versioned) /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk. This means a user have to install Command Line Tools to be able to compile extensions. I don't think there is a way to get around that.

If you add --dmg-out-dir [path] argument to ./build-grass.sh a dmg will be created at "path".

Please, do read the readme.

[cmbarton]

Sounds great. I’ll certainly read through the readme before I try it. A related question (maybe in readme). Does it create an app packaged with all dependencies inside, or does it use a local condo installation?

[nilason]

Everything is inside the app bundle.

[cmbarton]

I had some time and it seems very simple to run this. So I tried it several times. Compiling bombed every time with a bunch of errors for me. I include a short example below. But what I think the problem is that the patches are not being applied. The error is for a missing dylib as was the case before you fixed the patches. I did not apply them manually, but can try that this week. I looked at aclocal.m4 and I'm pretty sure that it has not been patched.

Note that I did a make clean and git stash/git pull to make sure I was working with clean source.

A couple other things I noticed. In the configure script, there is an argument for --without-readline. And at the end, is --with-readline and the needed paths.

Also, the process stops at install to ask for a sudo password. I was under the impression that installing with sudo could cause problems for users down the line. Maybe this is just old and no longer relevant. But at least you might want to note that users will need to enter an admin password during the installation.

Example error from one of the modules

(base) cmbarton@TCLASHE-C02Q40UVFY14 ~ % cd /Users/cmbarton/grass_source/grass/lib/vector/diglib

(base) cmbarton@TCLASHE-C02Q40UVFY14 diglib % make
if [ "" != "" -a -f "".html ] ; then /Applications/Xcode.app/Contents/Developer/usr/bin/make html ; fi
==============TEST=============
/Applications/Xcode.app/Contents/Developer/usr/bin/make test
cd OBJ.x86_64-apple-darwin19.6.0 && GISRC=/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/demolocation/.grassrc79 GISBASE=/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0 PATH="/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/scripts:$PATH" PYTHONPATH="/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/etc/python:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/gui/wxpython:$PYTHONPATH" DYLD_LIBRARY_PATH="/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/scripts:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/lib:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/lib:" LC_ALL=C LANG=C LANGUAGE=C ./test
dyld: Library not loaded: @rpath/libzstd.1.dylib
  Referenced from: /Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/lib/libgrass_gis.7.9.dylib
  Reason: image not found
/bin/sh: line 1: 48232 Abort trap: 6           GISRC=/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/demolocation/.grassrc79 GISBASE=/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0 PATH="/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/scripts:$PATH" PYTHONPATH="/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/etc/python:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/gui/wxpython:$PYTHONPATH" DYLD_LIBRARY_PATH="/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/scripts:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/lib:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/lib:" LC_ALL=C LANG=C LANGUAGE=C ./test
make[1]: *** [OBJ.x86_64-apple-darwin19.6.0/test.tmp] Error 134
make: *** [default] Error 2
(base) cmbarton@TCLASHE-C02Q40UVFY14 diglib % 

[nilason]

I have remade the patches, separate for 7.8.3, 7.8.4dev and 7.9dev, so that they are applied without error messages. I have tried them all, so they should work.

Please try with an absolutely clean source directory, I suggest for testing purposes download https://github.com/OSGeo/grass/archive/master.zip, unzip and set that directory to GRASSDIR config. Then if it still fails, please do email me the complete terminal output.

Thanks for noting, I will remove --without-readline, it's a leftover (but overridden by the others). Shouldn't cause any problems though.

Re: sudo. I will try removing it, I use it habitually to make install (in unix style install to default location in /usr/local/). Regardless of this, if I install from the resulting dmg by dragging to /Applications the app's file(s) owner is the user
's (no need for sudo for the user!).

[cmbarton]

I will try this and let you know.

[nilason]

Found a bug in this script and updated, please re-download this repo before testing.