Skip to content

Commit 23c2c53

Browse files
committed
deps: remove broken NamedPropertyDefinerCallbackV2 converter
This removal will be rolled in in a future V8 update too. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
1 parent 32ad50a commit 23c2c53

1 file changed

Lines changed: 0 additions & 20 deletions

File tree

‎deps/v8/include/v8-template.h‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -769,11 +769,6 @@ struct NamedPropertyHandlerConfiguration {
769769
NamedPropertySetterCallbackV2 value) {
770770
return value;
771771
}
772-
V8_DEPRECATED("Use NamedPropertySetterCallbackV2 setter instead")
773-
static NamedPropertySetterCallbackV2 ConvertSetter(
774-
NamedPropertySetterCallback value) {
775-
return NamedPropertySetterCallbackV2(value);
776-
}
777772

778773
static NamedPropertyDefinerCallbackV2 ConvertDefiner(std::nullptr_t) {
779774
return nullptr;
@@ -782,11 +777,6 @@ struct NamedPropertyHandlerConfiguration {
782777
NamedPropertyDefinerCallbackV2 value) {
783778
return value;
784779
}
785-
V8_DEPRECATED("Use NamedPropertyDefinerCallbackV2 definer instead")
786-
static NamedPropertyDefinerCallbackV2 ConvertDefiner(
787-
NamedPropertyDefinerCallback value) {
788-
return NamedPropertyDefinerCallbackV2(value);
789-
}
790780

791781
public:
792782
// TODO(https://crbug.com/348660658): cleanup once migration to
@@ -900,11 +890,6 @@ struct IndexedPropertyHandlerConfiguration {
900890
IndexedPropertySetterCallback value) {
901891
return value;
902892
}
903-
V8_DEPRECATED("Use IndexedPropertySetterCallback setter instead")
904-
static IndexedPropertySetterCallback ConvertSetter(
905-
IndexedPropertySetterCallbackV2 value) {
906-
return IndexedPropertySetterCallback(value);
907-
}
908893

909894
static IndexedPropertyDefinerCallback ConvertDefiner(std::nullptr_t) {
910895
return nullptr;
@@ -913,11 +898,6 @@ struct IndexedPropertyHandlerConfiguration {
913898
IndexedPropertyDefinerCallback value) {
914899
return value;
915900
}
916-
V8_DEPRECATED("Use IndexedPropertyDefinerCallback definer instead")
917-
static IndexedPropertyDefinerCallback ConvertDefiner(
918-
IndexedPropertyDefinerCallbackV2 value) {
919-
return IndexedPropertyDefinerCallback(value);
920-
}
921901

922902
public:
923903
// TODO(https://crbug.com/348660658): cleanup once migration to

0 commit comments

Comments
 (0)