quic: move pure-QUIC fields back from Http3Session to QuicSession

Author: pimterry

doc/api/quic.md

@@ -4248,10 +4248,11 @@ session should be used instead of the raw QUIC session for all HTTP/3
 interactions. The streams that this session exposes are still `QuicStream`
 instances, but they gain HTTP/3 APIs and functionality from the application.
 
-The HTTP/3 session API exposes all key HTTP/3 session details: the settings,
-statistics, TLS identity, and HTTP/3-level events. The QUIC transport details
-underneath (e.g. paths, transport parameters, and key updates) remain on the
-QUIC session, accessible as [`http3session.quicSession`][].
+The HTTP/3 session API exposes the HTTP/3 session details: the settings,
+statistics, and HTTP/3-level events. The connection details underneath (e.g.
+the TLS identity and negotiated ALPN, paths, transport parameters, and key
+updates) remain on the QUIC session, accessible as
+[`http3session.quicSession`][].
 
 HTTP/3 frames every stream on the connection, so once this is attached,
 streams cannot be opened on the QUIC session directly:
@@ -4305,9 +4306,8 @@ added: REPLACEME
 -->
 
 Each of the following behaves exactly as the member of the same name on the
-underlying [`QuicSession`][]: `alpnProtocol`, `certificate`, `close()`,
-`closed`, `destroy()`, `destroyed`, `ephemeralKeyInfo`, `opened`,
-`peerCertificate`, `servername`, and `stats`.
+underlying [`QuicSession`][]: `close()`, `closed`, `closing`, `destroy()`,
+`destroyed`, `opened`, and `stats`.
 
 Any callback set through the `Http3Session` - `onerror` and the
 HTTP/3-specific ones below - is invoked with the `Http3Session` as `this`.

lib/internal/quic/http3.js

@@ -206,21 +206,6 @@ class Http3Session {
    */
   get settings() { return this.#session.applicationOptions; }
 
-  /** @type {string|undefined} */
-  get servername() { return this.#session.servername; }
-
-  /** @type {string|undefined} */
-  get alpnProtocol() { return this.#session.alpnProtocol; }
-
-  /** @type {object|undefined} */
-  get certificate() { return this.#session.certificate; }
-
-  /** @type {object|undefined} */
-  get peerCertificate() { return this.#session.peerCertificate; }
-
-  /** @type {object|undefined} */
-  get ephemeralKeyInfo() { return this.#session.ephemeralKeyInfo; }
-
   /** @type {quic.QuicSession.Stats} */
   get stats() { return this.#session.stats; }
 
@@ -283,6 +268,9 @@ class Http3Session {
   /** @type {Promise<void>} */
   get closed() { return this.#session.closed; }
 
+  /** @type {boolean} */
+  get closing() { return this.#session.closing; }
+
   /** @type {boolean} */
   get destroyed() { return this.#session.destroyed; }
 

test/parallel/test-quic-h3-attach.mjs

@@ -69,10 +69,12 @@ assert.throws(() => new Http3Session(), { code: 'ERR_ILLEGAL_CONSTRUCTOR' });
   const client = Http3Session.from(quicClient);
   await client.opened;
 
-  assert.strictEqual(client.alpnProtocol, 'h3');
-  assert.strictEqual(client.servername, 'localhost');
+  // Connection details, TLS included, stay on the QUIC session:
+  assert.strictEqual(client.quicSession.alpnProtocol, 'h3');
+  assert.strictEqual(client.quicSession.servername, 'localhost');
+  assert.strictEqual('peerCertificate' in client, false);
   assert.strictEqual(typeof client.stats.createdAt, 'bigint');
-  assert.strictEqual(typeof client.ephemeralKeyInfo, 'object');
+  assert.strictEqual(client.closing, client.quicSession.closing);
   await client.close();
   await endpoint.close();
 }
@@ -126,7 +128,7 @@ const tooLate = {
   // Further already-settled awaits are still the same checkpoint.
   await null;
   const http3 = Http3Session.from(client);
-  assert.strictEqual(http3.alpnProtocol, 'h3');
+  assert.strictEqual(http3.quicSession, client);
   await http3.close();
   await endpoint.close();
 }