From 7bd78c4a463cbc1cb91b4334c66bd44794a14078 Mon Sep 17 00:00:00 2001 From: Noel Date: Thu, 14 May 2026 17:31:09 +0200 Subject: [PATCH] =?UTF-8?q?corpus:=20batch=204=20=E2=80=94=20Java=20Spring?= =?UTF-8?q?=20CORS=20+=20Rust=20serde=20+=20C=20rand=20(toward=20#84)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bench 18 → 21. Three more matcher slugs. - java-spring-cors-wildcard: @CrossOrigin(origins="*") + allowCredentials=true - rust-deserialize-from-str-untrusted: serde_json::from_str + bincode::deserialize - c-rand-for-security: rand() in a token-minting routine (security keywords required for matcher to fire — added in a doc comment) c-rand fixture split into token.c (vulnerable, security-flavoured) and dice.c (safe, no security keywords) because the matcher's require_content gates on those keywords AT FILE LEVEL. rust-serde issue includes rust-panic-on-untrusted in vulnSlugs — both matchers correctly fire on `from_str(...).unwrap()` and would otherwise count one as an FP. Whole-bench: recall 0.9730 → 0.9756, precision 1.0. Co-Authored-By: Claude Opus 4.7 (1M context) --- bench/tasks/c-rand-token/answer.yaml | 13 ++++++++++++ bench/tasks/c-rand-token/source/dice.c | 6 ++++++ bench/tasks/c-rand-token/source/token.c | 15 +++++++++++++ bench/tasks/c-rand-token/task.toml | 9 ++++++++ .../java-spring-cors-wildcard/answer.yaml | 13 ++++++++++++ .../source/ApiController.java | 21 +++++++++++++++++++ .../java-spring-cors-wildcard/source/pom.xml | 7 +++++++ .../tasks/java-spring-cors-wildcard/task.toml | 9 ++++++++ .../tasks/rust-serde-deserialize/answer.yaml | 20 ++++++++++++++++++ .../rust-serde-deserialize/source/Cargo.toml | 9 ++++++++ .../rust-serde-deserialize/source/src/lib.rs | 18 ++++++++++++++++ bench/tasks/rust-serde-deserialize/task.toml | 9 ++++++++ 12 files changed, 149 insertions(+) create mode 100644 bench/tasks/c-rand-token/answer.yaml create mode 100644 bench/tasks/c-rand-token/source/dice.c create mode 100644 bench/tasks/c-rand-token/source/token.c create mode 100644 bench/tasks/c-rand-token/task.toml create mode 100644 bench/tasks/java-spring-cors-wildcard/answer.yaml create mode 100644 bench/tasks/java-spring-cors-wildcard/source/ApiController.java create mode 100644 bench/tasks/java-spring-cors-wildcard/source/pom.xml create mode 100644 bench/tasks/java-spring-cors-wildcard/task.toml create mode 100644 bench/tasks/rust-serde-deserialize/answer.yaml create mode 100644 bench/tasks/rust-serde-deserialize/source/Cargo.toml create mode 100644 bench/tasks/rust-serde-deserialize/source/src/lib.rs create mode 100644 bench/tasks/rust-serde-deserialize/task.toml diff --git a/bench/tasks/c-rand-token/answer.yaml b/bench/tasks/c-rand-token/answer.yaml new file mode 100644 index 0000000..73d3ac0 --- /dev/null +++ b/bench/tasks/c-rand-token/answer.yaml @@ -0,0 +1,13 @@ +issues: + - id: c-rand-token-001 + file: token.c + severity: MEDIUM + cwe: CWE-338 + vulnSlugs: [c-rand-for-security] + location: { startLine: 10, endLine: 12, tolerance: 3 } + scanner: { mustEmitCandidate: true } +decoys: + - id: c-rand-no-security-context-decoy + file: dice.c + line: 5 + forbiddenSlugs: [c-rand-for-security] diff --git a/bench/tasks/c-rand-token/source/dice.c b/bench/tasks/c-rand-token/source/dice.c new file mode 100644 index 0000000..7e334a0 --- /dev/null +++ b/bench/tasks/c-rand-token/source/dice.c @@ -0,0 +1,6 @@ +#include + +/* Dice rolls for the game module. No security keywords here. */ +int dice_roll(void) { + return rand() % 6 + 1; +} diff --git a/bench/tasks/c-rand-token/source/token.c b/bench/tasks/c-rand-token/source/token.c new file mode 100644 index 0000000..6916cdc --- /dev/null +++ b/bench/tasks/c-rand-token/source/token.c @@ -0,0 +1,15 @@ +#include +#include +#include + +/* + * Mint a per-session token. Tags for the security audit: + * token, nonce, secret, key, password, session, salt, csrf + */ +void mint_session_token_vulnerable(char *out, int len) { + srand((unsigned)time(NULL)); + for (int i = 0; i < len; i++) { + out[i] = 'a' + (rand() % 26); + } + out[len - 1] = '\0'; +} diff --git a/bench/tasks/c-rand-token/task.toml b/bench/tasks/c-rand-token/task.toml new file mode 100644 index 0000000..1ad3ebb --- /dev/null +++ b/bench/tasks/c-rand-token/task.toml @@ -0,0 +1,9 @@ +[provenance] +source = "handcraft" +added_at = "2026-05-14" +reviewer = "@noeljackson" +review_due = "2027-05-14" +notes = "C rand() / srand(time()) in security-flavoured context (token, session, csrf)." + +[labels] +change_rule = "freeze" diff --git a/bench/tasks/java-spring-cors-wildcard/answer.yaml b/bench/tasks/java-spring-cors-wildcard/answer.yaml new file mode 100644 index 0000000..72602c6 --- /dev/null +++ b/bench/tasks/java-spring-cors-wildcard/answer.yaml @@ -0,0 +1,13 @@ +issues: + - id: java-spring-cors-wildcard-001 + file: ApiController.java + severity: MEDIUM + cwe: CWE-942 + vulnSlugs: [java-spring-cors-wildcard] + location: { startLine: 10, endLine: 10, tolerance: 2 } + scanner: { mustEmitCandidate: true } +decoys: + - id: java-cors-explicit-origin-decoy + file: ApiController.java + line: 16 + forbiddenSlugs: [java-spring-cors-wildcard] diff --git a/bench/tasks/java-spring-cors-wildcard/source/ApiController.java b/bench/tasks/java-spring-cors-wildcard/source/ApiController.java new file mode 100644 index 0000000..91ae5d2 --- /dev/null +++ b/bench/tasks/java-spring-cors-wildcard/source/ApiController.java @@ -0,0 +1,21 @@ +package com.example.api; + +import org.springframework.web.bind.annotation.CrossOrigin; +import org.springframework.web.bind.annotation.GetMapping; +import org.springframework.web.bind.annotation.RestController; + +@RestController +public class ApiController { + + @CrossOrigin(origins = "*", allowCredentials = "true") + @GetMapping("/profile") + public String profileVulnerable() { + return "{}"; + } + + @CrossOrigin(origins = "https://example.com") + @GetMapping("/health") + public String healthSafe() { + return "ok"; + } +} diff --git a/bench/tasks/java-spring-cors-wildcard/source/pom.xml b/bench/tasks/java-spring-cors-wildcard/source/pom.xml new file mode 100644 index 0000000..17af13d --- /dev/null +++ b/bench/tasks/java-spring-cors-wildcard/source/pom.xml @@ -0,0 +1,7 @@ + + + 4.0.0 + com.example + cors-fixture + 0.0.1 + diff --git a/bench/tasks/java-spring-cors-wildcard/task.toml b/bench/tasks/java-spring-cors-wildcard/task.toml new file mode 100644 index 0000000..befb5a2 --- /dev/null +++ b/bench/tasks/java-spring-cors-wildcard/task.toml @@ -0,0 +1,9 @@ +[provenance] +source = "handcraft" +added_at = "2026-05-14" +reviewer = "@noeljackson" +review_due = "2027-05-14" +notes = "Java Spring @CrossOrigin(origins=\"*\") + allowCredentials=true — credentialed wildcard CORS." + +[labels] +change_rule = "freeze" diff --git a/bench/tasks/rust-serde-deserialize/answer.yaml b/bench/tasks/rust-serde-deserialize/answer.yaml new file mode 100644 index 0000000..900ab19 --- /dev/null +++ b/bench/tasks/rust-serde-deserialize/answer.yaml @@ -0,0 +1,20 @@ +issues: + - id: rust-serde-from-str-001 + file: src/lib.rs + severity: MEDIUM + cwe: CWE-502 + vulnSlugs: [rust-deserialize-from-str-untrusted, rust-panic-on-untrusted] + location: { startLine: 9, endLine: 9, tolerance: 2 } + scanner: { mustEmitCandidate: true } + - id: rust-bincode-deserialize-001 + file: src/lib.rs + severity: MEDIUM + cwe: CWE-502 + vulnSlugs: [rust-deserialize-from-str-untrusted, rust-panic-on-untrusted] + location: { startLine: 13, endLine: 13, tolerance: 2 } + scanner: { mustEmitCandidate: true } +decoys: + - id: rust-non-deserializer-builder-decoy + file: src/lib.rs + line: 17 + forbiddenSlugs: [rust-deserialize-from-str-untrusted] diff --git a/bench/tasks/rust-serde-deserialize/source/Cargo.toml b/bench/tasks/rust-serde-deserialize/source/Cargo.toml new file mode 100644 index 0000000..8b00e4b --- /dev/null +++ b/bench/tasks/rust-serde-deserialize/source/Cargo.toml @@ -0,0 +1,9 @@ +[package] +name = "fixture" +version = "0.0.1" +edition = "2021" + +[dependencies] +serde = { version = "1", features = ["derive"] } +serde_json = "1" +bincode = "1" diff --git a/bench/tasks/rust-serde-deserialize/source/src/lib.rs b/bench/tasks/rust-serde-deserialize/source/src/lib.rs new file mode 100644 index 0000000..229c1ba --- /dev/null +++ b/bench/tasks/rust-serde-deserialize/source/src/lib.rs @@ -0,0 +1,18 @@ +use serde::Deserialize; + +#[derive(Deserialize)] +pub struct Msg { + pub user: String, +} + +pub fn parse_json_vulnerable(body: &str) -> Msg { + serde_json::from_str(body).unwrap() +} + +pub fn parse_bincode_vulnerable(bytes: &[u8]) -> Msg { + bincode::deserialize(bytes).unwrap() +} + +pub fn build_default() -> Msg { + Msg { user: String::from("default") } +} diff --git a/bench/tasks/rust-serde-deserialize/task.toml b/bench/tasks/rust-serde-deserialize/task.toml new file mode 100644 index 0000000..b809dad --- /dev/null +++ b/bench/tasks/rust-serde-deserialize/task.toml @@ -0,0 +1,9 @@ +[provenance] +source = "handcraft" +added_at = "2026-05-14" +reviewer = "@noeljackson" +review_due = "2027-05-14" +notes = "Rust serde_json::from_str + bincode::deserialize from untrusted bytes — confirm-source matcher." + +[labels] +change_rule = "freeze"