Full UUID search#14
Open
peterjwest wants to merge 14 commits into
Open
Conversation
peterjwest
force-pushed
the
feature/full-search
branch
4 times, most recently
from
b7c70a1 to
d447f03
Compare
peterjwest
force-pushed
the
feature/full-search
branch
2 times, most recently
from
f69ba4c to
d2238ec
Compare
peterjwest
force-pushed
the
feature/full-search
branch
from
d2238ec to
6b96eaa
Compare
Also more natural dragging behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds fully working search, as discussed here: #12
Huge thanks to @wangqr, this would not have been possible without them.
Replaces the Feistal cipher with a random invertible matrix transformation, which does unfortunately mean the UUID order would have to change to accommodate this feature.
The only major problem with this currently is that I use @csquare/random-bytes-seed which is designed to be used server side, requiring a bunch of polyfills and bloating the build size. I'm going to look for an alternative, but I figured I'd show the feature for now.I've replaced this with random-bytes-seed which does still require Buffer as a polyfill, but is much smaller.
I've also updated the site to allow search to wrap correctly when there are results on the last page. I added a slight highlight to the current search item to make this clearer. I upgraded the scroll logic to only scroll when the search result is out of view (like a browser does), and fixed searching of favourites.
I also noticed the scroll handle didn't resize for the favourites and fixed that.
Have not added tests, but happy to!