D4D_ORIENT_PORTRAIT180 buffer shifted by one line

[faghio]

It looks like line 234 of d4d_lcd_frame_buffer.c:

win_const1 = (signed long)(p_fbDesc->fb_start_addr + (p_fbDesc->lcd_x_max * win_x + p_fbDesc->lcd_x_max - win_y) * bpp_byte);

needs to be changed into:

win_const1 = (signed long)(p_fbDesc->fb_start_addr + (p_fbDesc->lcd_x_max * win_x + p_fbDesc->lcd_x_max - win_y - 1) * bpp_byte);

(-1 added) otherwise an LCD used with D4D_ORIENT_PORTRAIT180 orientation will show the first horizontal line of screen on the bottom (the whole screen is "rolled" up by 1 line).

Do you agree?

[Gargy007]

I have to be :-).

This orientation I never tested. If you can create push request, with the
change.

Thank you
Petr

2015-06-17 12:47 GMT+02:00 faghio notifications@github.com:

It looks like line 234 of d4d_lcd_frame_buffer.c:

win_const1 = (signed long)(p_fbDesc->fb_start_addr + (p_fbDesc->lcd_x_max * win_x + p_fbDesc->lcd_x_max - win_y) * bpp_byte);

needs to be changed into:

win_const1 = (signed long)(p_fbDesc->fb_start_addr + (p_fbDesc->lcd_x_max * win_x + p_fbDesc->lcd_x_max - win_y - 1) * bpp_byte);

(-1 added) otherwise an LCD used with D4D_ORIENT_PORTRAIT180 orientation
will show the first horizontal line of screen on the bottom (the whole
screen is "rolled" up by 1 line).

Do you agree?

—
Reply to this email directly or view it on GitHub
https://github.com/Gargy007/eGUI/issues/15.

[Gargy007]

Sorry I didn't finish my sentence :-)

So:

This orientation I never tested. If you can create push request, with the
change_, then I will be more than happy._

Thank you

2015-06-17 12:49 GMT+02:00 Petr Gargulak petr.gargulak@gmail.com:

I have to be :-).

This orientation I never tested. If you can create push request, with the
change.

Thank you
Petr

2015-06-17 12:47 GMT+02:00 faghio notifications@github.com:

It looks like line 234 of d4d_lcd_frame_buffer.c:

win_const1 = (signed long)(p_fbDesc->fb_start_addr + (p_fbDesc->lcd_x_max * win_x + p_fbDesc->lcd_x_max - win_y) * bpp_byte);

needs to be changed into:

win_const1 = (signed long)(p_fbDesc->fb_start_addr + (p_fbDesc->lcd_x_max * win_x + p_fbDesc->lcd_x_max - win_y - 1) * bpp_byte);

(-1 added) otherwise an LCD used with D4D_ORIENT_PORTRAIT180 orientation
will show the first horizontal line of screen on the bottom (the whole
screen is "rolled" up by 1 line).

Do you agree?

—
Reply to this email directly or view it on GitHub
https://github.com/Gargy007/eGUI/issues/15.

[faghio]

OK done.

[Gargy007]

Also,
Thank you
Petr

2015-06-17 14:24 GMT+02:00 faghio notifications@github.com:

OK done.

—
Reply to this email directly or view it on GitHub
https://github.com/Gargy007/eGUI/issues/15#issuecomment-112780168.