Skip to content

Commit 4d3c812

Browse files
Claudeclaude
andcommitted
docs(automation): name the source of the approval status list (#3786)
The docs-drift check turned up a FOURTH copy of the status set, in the highest- visibility place: `automation/approvals.mdx`'s "Statuses in full" line. Unlike the CORS case in #4282 this one is correct today — all five values, same order — so there is nothing to fix, only something unguarded. Points at APPROVAL_STATUSES and says plainly that this line is a copy nothing updates automatically. That is weaker than derivation and I am not pretending otherwise: prose docs legitimately restate values, and a path-coupled test asserting this exact sentence would be brittle. Recorded as a follow-up instead — `check:variant-docs` already solves this shape for schema variants and is the right place to extend if the set starts moving. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UXGj3Z5TmwSV6RK2oGc3cb
1 parent 37bd21b commit 4d3c812

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

content/docs/automation/approvals.mdx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,11 @@ On finalization the request row gets `status: 'approved'` (or `'rejected'`),
395395
mirrored to the same value, and the record unlocks. The parked run resumes down
396396
the `approve` or `reject` branch.
397397

398-
Statuses in full: `pending`, `approved`, `rejected`, `recalled`, `returned`.
398+
Statuses in full: `pending`, `approved`, `rejected`, `recalled`, `returned`
399+
the `APPROVAL_STATUSES` constant in `@objectstack/spec/contracts`, which is also
400+
what `sys_approval_request.status` offers and what `ApprovalStatus` is derived
401+
from. If you add a status there, this line is a fourth copy that nothing updates
402+
for you.
399403

400404
</Steps>
401405

0 commit comments

Comments
 (0)