diff --git a/CHANGES.md b/CHANGES.md index 9f625a7ad..e5dfc98e7 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,5 +1,15 @@ # NEXT +* Fix the development-profile build with recent compilers: anonymize + unused functor parameters in printer and functor signatures + (warning 67) +* Breaking: the `hidden` attribute now takes an enumerated argument + ([`Hidden | `Until_found]) instead of no argument, and + `contenteditable` takes an enumerated argument + ([`True | `False | `Plaintext_only]) instead of a boolean, to + support the until-found and plaintext-only states +* Undeprecate the `scope` attribute: it is valid in the HTML living + standard on table header cells * Fix typo `whitout` in type definition (#324 by Martin @MBodin Bodin) * Add support for the clip-path presentation attribute diff --git a/lib/html_f.ml b/lib/html_f.ml index d163a82e4..5d603706b 100644 --- a/lib/html_f.ml +++ b/lib/html_f.ml @@ -307,8 +307,8 @@ struct let a_challenge = string_attrib "challenge" - let a_contenteditable ce = - bool_attrib "contenteditable" ce + let a_contenteditable x = + user_attrib C.string_of_big_variant "contenteditable" x let a_contextmenu = string_attrib "contextmenu" @@ -332,8 +332,8 @@ struct let a_formtarget = string_attrib "formtarget" - let a_hidden = - constant_attrib "hidden" + let a_hidden x = + user_attrib C.string_of_big_variant "hidden" x let a_high = float_attrib "high" @@ -1001,6 +1001,10 @@ struct | `One -> "1" | `Yes -> "yes" | `No -> "no" + | `True -> "true" + | `False -> "false" + | `Plaintext_only -> "plaintext-only" + | `Until_found -> "until-found" | `Auto -> "auto" | `Circle -> "circle" | `Poly -> "poly" diff --git a/lib/html_f.mli b/lib/html_f.mli index 647c57c49..4c3ae76eb 100644 --- a/lib/html_f.mli +++ b/lib/html_f.mli @@ -46,7 +46,7 @@ module Wrapped_functions (** Similar to {!Make} but with a custom set of wrapped functions. *) module Make_with_wrapped_functions (Xml : Xml_sigs.T) - (C : Html_sigs.Wrapped_functions with module Xml = Xml) + (_ : Html_sigs.Wrapped_functions with module Xml = Xml) (Svg : Svg_sigs.T with module Xml := Xml) : Html_sigs.Make(Xml)(Svg).T with type +'a elt = Xml.elt diff --git a/lib/html_sigs.mli b/lib/html_sigs.mli index 60750f6c7..d15f9c63f 100644 --- a/lib/html_sigs.mli +++ b/lib/html_sigs.mli @@ -282,7 +282,12 @@ module type T = sig val a_challenge : text wrap -> [> | `Challenge] attrib - val a_contenteditable : bool wrap -> [> | `Contenteditable] attrib + val a_contenteditable : + contenteditable_value wrap -> [> | `Contenteditable] attrib + (** A bare [contenteditable] attribute is equivalent to + [contenteditable="true"]. + @see + contenteditable attribute documentation on MDN *) val a_contextmenu : idref wrap -> [> | `Contextmenu] attrib @@ -302,7 +307,11 @@ module type T = sig val a_formtarget : text wrap -> [> | `Formtarget] attrib - val a_hidden : unit -> [> | `Hidden] attrib + val a_hidden : hidden_value wrap -> [> | `Hidden] attrib + (** A bare [hidden] attribute is equivalent to [hidden="hidden"]; + use [`Until_found] for the hidden-until-found state. + @see