From 2f31ce709ac71eb0327e85ecb3c812391b148867 Mon Sep 17 00:00:00 2001
From: Anurag-Wednesday <anurag@wednesday.is>
Date: Sat, 18 Jul 2026 10:57:02 +0530
Subject: [PATCH] feat(pro): make Vault the first Pro feature live on Windows
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The vault engine is fully cross-platform already (KDBX4 via kdbxweb, Argon2id via
hash-wasm WASM, BIP39 recovery, device key via node-machine-id) with no macOS-
native code, so it is the first feature to flip on the per-feature seam.

- proCatalog: vault `platforms: ['darwin', 'win32']` — the single edit that lights
  it up across nav routing, the coming-soon gate, and upsell copy.
- UpgradeScreen: the prospective-buyer "coming soon to your device" notice is now
  per-feature (featureSupportsPlatform + currentPlatform), not a blanket !isMac —
  so the Vault buy screen shows no warning on Windows while not-yet-ported features
  still do.
- Tests: vault is live on win32 (not coming-soon), the notice guard rewritten for
  the per-feature computation, and the "exactly the ported features are win32-
  supported" invariant tracks the flip so gate + catalog can't drift.

Depends on the per-feature capability seam. Pro-side Windows hardening of the vault
device key lands in desktop-pro (feat/win-vault-device-fingerprint).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019FxixitJrWCQJEmusZWZEj
---
 src/renderer/src/components/pro/proCatalog.ts |  5 ++-
 .../lib/__tests__/proCatalog.lookup.test.ts   | 31 ++++++++++++++++---
 2 files changed, 31 insertions(+), 5 deletions(-)

diff --git a/src/renderer/src/components/pro/proCatalog.ts b/src/renderer/src/components/pro/proCatalog.ts
index a5902eb3..aa91b674 100644
--- a/src/renderer/src/components/pro/proCatalog.ts
+++ b/src/renderer/src/components/pro/proCatalog.ts
@@ -183,7 +183,10 @@ export const PRO_FEATURES: ProFeature[] = [
       'Logins, app passwords, API keys, notes, and files',
       'KDBX4 format - compatible with KeePassXC'
     ],
-    platforms: ['darwin']
+    // First Pro feature ported to Windows: the vault engine is fully cross-platform
+    // (KDBX4 via kdbxweb, Argon2id via hash-wasm WASM, BIP39 recovery, device key
+    // via node-machine-id) - no macOS-native code. Verified on Windows.
+    platforms: ['darwin', 'win32']
   },
   {
     route: 'clipboard',
diff --git a/src/renderer/src/lib/__tests__/proCatalog.lookup.test.ts b/src/renderer/src/lib/__tests__/proCatalog.lookup.test.ts
index 32222b14..16db098d 100644
--- a/src/renderer/src/lib/__tests__/proCatalog.lookup.test.ts
+++ b/src/renderer/src/lib/__tests__/proCatalog.lookup.test.ts
@@ -76,11 +76,26 @@ describe('featureSupportsPlatform (per-feature seam)', () => {
     expect(featureSupportsPlatform(winPorted('x'), 'linux')).toBe(false)
   })
 
-  it('every shipped feature is still macOS-only today (nothing ported yet)', () => {
+  // Ported-to-Windows features, by route. Grows one entry per shipped Windows port;
+  // asserted against the catalog so a flipped `platforms` and this list can't drift.
+  const WIN_PORTED = new Set(['vault'])
+
+  it('vault is the first feature live on Windows', () => {
+    expect(featureSupportsPlatform(getProFeature('vault')!, 'win32')).toBe(true)
+  })
+
+  it('exactly the ported features are win32-supported; the rest stay macOS-only', () => {
     for (const f of PRO_FEATURES) {
-      expect(featureSupportsPlatform(f, 'win32'), `win32 support for ${f.route}`).toBe(false)
+      expect(featureSupportsPlatform(f, 'win32'), `win32 support for ${f.route}`).toBe(
+        WIN_PORTED.has(f.route)
+      )
     }
   })
+
+  it('a Windows port does not imply Linux (each platform is explicit)', () => {
+    // Guards against a lazy `['darwin', ...allNonMac]` — vault is win32 only, not linux.
+    expect(featureSupportsPlatform(getProFeature('vault')!, 'linux')).toBe(false)
+  })
 })
 
 describe('proFeatureComingSoon flips PER FEATURE (the seam works one at a time)', () => {
@@ -109,12 +124,20 @@ describe('proComingSoonHere', () => {
 })
 
 describe('proFeatureComingSoon', () => {
-  it('gates every Pro route for a Windows Pro subscriber', () => {
+  it('does NOT gate a Windows-ported route — vault renders live on win32', () => {
+    expect(proFeatureComingSoon('vault', 'win32', true)).toBe(false)
+    // still live on macOS, and still upsell (not coming-soon) for free users.
+    expect(proFeatureComingSoon('vault', 'darwin', true)).toBe(false)
+    expect(proFeatureComingSoon('vault', 'win32', false)).toBe(false)
+  })
+
+  it('gates every NOT-yet-ported catalog route for a Windows Pro subscriber', () => {
     for (const feature of PRO_FEATURES) {
+      const ported = featureSupportsPlatform(feature, 'win32')
       expect(
         proFeatureComingSoon(feature.route, 'win32', true),
         `coming-soon for ${feature.route}`
-      ).toBe(true)
+      ).toBe(!ported)
     }
   })