From 7bdc7439d955a8086876c2142dac24e4ea4905c1 Mon Sep 17 00:00:00 2001 From: Scott Jones Date: Sat, 24 Oct 2026 02:06:18 -0400 Subject: [PATCH] media: apple: isp: use temporal filter zero on J615 firmware 14.7 too garymeyerca's 4433ef5a0de (#199) makes the J613 (13-inch M3 MacBook Air) use temporal filter 0 on ISP firmware 14.7, where filter 1 delivers no frames. The J615 (15-inch) has the same sensor and ISP configuration: t8122-j615.dts includes isp-imx558-cfg0.dtsi and sets platform-id 18 and temporal-filter 1, exactly as t8122-j613.dts does. So it very likely stalls the same way. Apply the workaround to the J615 too. This is untested on a J615; the J613 result is from 7.2.11 with Gary's series. Co-Authored-By: Claude Opus 5.5 (1M context) Signed-off-by: Scott Jones --- drivers/media/platform/apple/isp/isp-drv.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/apple/isp/isp-drv.c b/drivers/media/platform/apple/isp/isp-drv.c index ead021d7c3317a..2cbdcd2fb00bde 100644 --- a/drivers/media/platform/apple/isp/isp-drv.c +++ b/drivers/media/platform/apple/isp/isp-drv.c @@ -421,11 +421,16 @@ static int apple_isp_probe(struct platform_device *pdev) if (err) isp->temporal_filter = 0; - /* J613 firmware 14.7 stalls capture with temporal filter 1. */ - if (of_machine_is_compatible("apple,j613") && + /* + * M3 MacBook Air firmware 14.7 stalls capture with temporal filter 1. + * The J615 has the J613's sensor and ISP configuration; only the J613 + * has been tested. + */ + if ((of_machine_is_compatible("apple,j613") || + of_machine_is_compatible("apple,j615")) && isp->fw_compat == ISP_FIRMWARE_V_14_7 && isp->temporal_filter == 1) { - dev_info(dev, "using temporal filter 0 on J613 firmware 14.7\n"); + dev_info(dev, "using temporal filter 0 on M3 Air firmware 14.7\n"); isp->temporal_filter = 0; }