From 82d61a9bccba329fbee8971f10792bb76c6a77f3 Mon Sep 17 00:00:00 2001
From: Nils-Paul Korte <192386710+NPK111@users.noreply.github.com>
Date: Tue, 3 Nov 2026 11:27:18 +0100
Subject: [PATCH] Remove local cache on Windows uninstall

---
 docs/README.md                                           | 5 +++++
 .../StudioComponents.wxs                                 | 9 +++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/docs/README.md b/docs/README.md
index c8cabac2..64bf5b67 100644
--- a/docs/README.md
+++ b/docs/README.md
@@ -174,6 +174,11 @@ Messages that arrive while Studio is still starting are queued until startup con
 | Packages, plugins, native tools | `~/OneWareStudio/Packages` |
 | Projects | `~/OneWareStudio/Projects` |
 | Settings and layouts | `%APPDATA%\OneWareStudio` (Windows), `~/.config/OneWareStudio` (Linux), `~/Library/Application Support/OneWareStudio` (macOS) |
+| Cache | `%LOCALAPPDATA%\OneWareStudio` (Windows), `${XDG_CACHE_HOME:-~/.cache}/OneWareStudio` (Linux), `~/Library/Caches/OneWareStudio` (macOS) |
+
+On Windows, uninstalling removes the current user's default cache. Settings, packages and projects are
+kept unless user data removal is selected; updates keep the cache and user data. With a custom
+`ONEWARE_APPDATA_DIR`, the cache is stored in its `Cache` subdirectory instead.
 
 ## Building, testing and packaging
 
diff --git a/studio/OneWare.Studio.Desktop.WindowsInstaller/StudioComponents.wxs b/studio/OneWare.Studio.Desktop.WindowsInstaller/StudioComponents.wxs
index f6b59b6e..20f7efe8 100644
--- a/studio/OneWare.Studio.Desktop.WindowsInstaller/StudioComponents.wxs
+++ b/studio/OneWare.Studio.Desktop.WindowsInstaller/StudioComponents.wxs
@@ -4,11 +4,12 @@
              the RemoveFolderEx custom action -->
         <Property Id="ONEWAREAPPDATAFOLDER" Value="%APPDATA%\OneWareStudio" />
         <Property Id="ONEWAREDOCUMENTSFOLDER" Value="%USERPROFILE%\OneWareStudio" />
+        <Property Id="ONEWARECACHEFOLDER" Value="%LOCALAPPDATA%\OneWareStudio" />
 
         <ComponentGroup Id="StudioComponents" Directory="INSTALLFOLDER">
 
-            <!-- Removes settings and documents on uninstall, but only if the user opted in.
-                 Never runs while updating, because UPGRADINGPRODUCTCODE is set in that case -->
+            <!-- Settings and documents are removed only if the user opted in; the cache is
+                 always removed on uninstall. Neither cleanup runs during an upgrade. -->
             <Component Id="UserDataCleanupComponent" Guid="{2c74addf-161c-49ef-a3a9-d828c5b3dc56}">
                 <RegistryValue Root="HKLM" Key="Software\!(loc.Company)\!(loc.ProductNameFolder)"
                     Name="InstallFolder" Value="[INSTALLFOLDER]" Type="string" KeyPath="yes" />
@@ -20,6 +21,10 @@
                 <util:RemoveFolderEx Id="RemoveDocumentsFolder" On="uninstall"
                     Property="ONEWAREDOCUMENTSFOLDER"
                     Condition="REMOVEUSERDATA = &quot;1&quot; AND NOT UPGRADINGPRODUCTCODE" />
+
+                <util:RemoveFolderEx Id="RemoveCacheFolder" On="uninstall"
+                    Property="ONEWARECACHEFOLDER"
+                    Condition="NOT UPGRADINGPRODUCTCODE" />
             </Component>
 
             <Component Id="OneWareStudioExeComponent" Guid="{7a73a50a-c9e7-4511-af5d-642296257da6}">