From c4428e6fea23fce5c839f0c033b9b54b10212f82 Mon Sep 17 00:00:00 2001 From: Andy Bavier Date: Fri, 23 Jan 2026 08:04:47 -0700 Subject: [PATCH 1/2] Prefix 'v' to tags using add_v flag Signed-off-by: Andy Bavier --- .github/workflows/push.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml index e813851..8be779e 100644 --- a/.github/workflows/push.yml +++ b/.github/workflows/push.yml @@ -17,6 +17,8 @@ jobs: # CAUTION: Other actions depend on this name "tag-github" tag-github: uses: onosproject/.github/.github/workflows/tag-github.yml@main + with: + add_v: true secrets: inherit release-image: @@ -30,8 +32,7 @@ jobs: attestations: write uses: onosproject/.github/.github/workflows/release-image.yml@main with: - # Prefix the version with 'v' to follow tagging conventions - docker_tag: v${{ needs.tag-github.outputs.version }} + docker_tag: ${{ needs.tag-github.outputs.version }} secrets: inherit update-version: @@ -40,5 +41,4 @@ jobs: uses: onosproject/.github/.github/workflows/bump-version.yml@main secrets: inherit with: - # Prefix the version with 'v' to follow tagging conventions - version: v${{ needs.tag-github.outputs.version }} + version: ${{ needs.tag-github.outputs.version }} From dd9b70b10948092ef6e748477b5f3ab9f033f84d Mon Sep 17 00:00:00 2001 From: Andy Bavier Date: Fri, 23 Jan 2026 10:36:50 -0700 Subject: [PATCH 2/2] Remove obsolete parameter from update-version Signed-off-by: Andy Bavier --- .github/workflows/push.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml index 8be779e..a7b0697 100644 --- a/.github/workflows/push.yml +++ b/.github/workflows/push.yml @@ -14,13 +14,16 @@ permissions: contents: read jobs: - # CAUTION: Other actions depend on this name "tag-github" + # Tag GitHub Release + # The convention is to prefix the version with a 'v', e.g., v1.2.3 tag-github: uses: onosproject/.github/.github/workflows/tag-github.yml@main with: add_v: true secrets: inherit + # Build and Release Docker Image + # The convention is to use the same tag for the Docker image as the GitHub Release release-image: needs: tag-github if: needs.tag-github.outputs.changed == 'true' @@ -35,10 +38,9 @@ jobs: docker_tag: ${{ needs.tag-github.outputs.version }} secrets: inherit + # Bump Version update-version: needs: tag-github if: needs.tag-github.outputs.changed == 'true' uses: onosproject/.github/.github/workflows/bump-version.yml@main secrets: inherit - with: - version: ${{ needs.tag-github.outputs.version }}