Skip to content

feat: add argentina_buenos_aires, handle multiple CSV files in pipeline#1255

Open
yolile wants to merge 1 commit into
mainfrom
1202-buenos-aires
Open

feat: add argentina_buenos_aires, handle multiple CSV files in pipeline#1255
yolile wants to merge 1 commit into
mainfrom
1202-buenos-aires

Conversation

@yolile
Copy link
Copy Markdown
Member

@yolile yolile commented Mar 24, 2026

This was the implementation by Claude (with some review from my side)
But I don't think we can merge this because the CSV files are large, and the flatten tool consumed>60% of the available memory on the server when I tried it. I've killed the spider before it finished because the memory was getting higher and higher.

ref #1202

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 36.11111% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.75%. Comparing base (50b0aed) to head (4f60ae6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kingfisher_scrapy/pipelines.py 34.28% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
- Coverage   91.88%   90.75%   -1.14%     
==========================================
  Files          29       29              
  Lines        1651     1687      +36     
==========================================
+ Hits         1517     1531      +14     
- Misses        134      156      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpmckinney
Copy link
Copy Markdown
Member

How big / how many are the CSVs?

Flatten Tool is not memory efficient, that's for sure.

@yolile
Copy link
Copy Markdown
Member Author

yolile commented Mar 24, 2026

543M - award.csv
373M - contracts.csv
230M - parties.csv
568M - tender.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants