feat: add argentina_buenos_aires, handle multiple CSV files in pipeline#1255
Open
yolile wants to merge 1 commit into
Open
feat: add argentina_buenos_aires, handle multiple CSV files in pipeline#1255yolile wants to merge 1 commit into
yolile wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
==========================================
- Coverage 91.88% 90.75% -1.14%
==========================================
Files 29 29
Lines 1651 1687 +36
==========================================
+ Hits 1517 1531 +14
- Misses 134 156 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
How big / how many are the CSVs? Flatten Tool is not memory efficient, that's for sure. |
Member
Author
|
543M - award.csv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was the implementation by Claude (with some review from my side)
But I don't think we can merge this because the CSV files are large, and the flatten tool consumed>60% of the available memory on the server when I tried it. I've killed the spider before it finished because the memory was getting higher and higher.
ref #1202