CMakeLists.txt can not find pugixml.hpp, and how can I install the built python module

[qingfengxia]

I can not follow the guidance to build, with openmc installed to /opt/openmc
but i can pip install parametric-plasma-source not sure how compatible it is with other components.

I had a few concern like
such as "find_package(OpenMC)", but if my openmc is not installed to /usr/ there is no OpenMC.config for cmake to find package. if it is requred to install openmc to /usr, it should be stated in readme.md?

================== 1) ======================================
cmake is fine, but make got error like this. and later "openmc/bank.h"

/home/jovyan/parametric-plasma-source/parametric_plasma_source/source_generator.cpp:4:10: fatal error: pugixml.hpp: No such file or directory
4 | #include "pugixml.hpp"
| ^~~~~~~~~~~~~

The solution, could be
replace:
target_include_directories(source_generator PUBLIC ${OPENMC_DIR}/vendor/pugixml)

to use openmc repo's

target_include_directories(source_generator PUBLIC ${OPENMC_DIR}/vendor/pugixml/src)

to use the git submodule

target_include_directories(source_generator PUBLIC ${PROJECT_SOURCE_DIR}/pugixml/src)

=========== 2) =========
I do not understand, why?

if(OpenMC_FOUND)
  # Build the source_sampling OpenMC plugin if OpenMC is available
  set(OPENMC_INC_DIR ${OpenMC_DIR}/../../../include/openmc)
  set(OPENMC_LIB_DIR ${OpenMC_DIR}/../../../lib)

is that because, I am on master branch, some cmake edit has not been merged?

=========== 3) ============
the installation guide, said "make install" but python binary module should not install to "/usr/lib"? anyway, I have not yet get this step to test out

[makeclean]

There's no need to install it anywhere specifically, but the findopenmc.cmake has to be clever enough to know. Ultimately the openmc.xmake can usually be found in the lib directory

…

________________________________ From: Qingfeng Xia <notifications@github.com> Sent: Monday, November 9, 2020 2:49:57 PM To: open-radiation-sources/parametric-plasma-source <parametric-plasma-source@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: [open-radiation-sources/parametric-plasma-source] CMakeLists.txt can not find pugixml.hpp, and how can I install the built python module (#17) I can not follow the guidance, with openmc installed to /opt/openmc such as "find_package(OpenMC)", but if my openmc is not installed to /usr/ there is no OpenMC.config for cmake to find package. if it is requred to install openmc to /usr, it should be stated in readme.md? ================== 1) ====================================== cmake is fine, but make got error like this. and later "openmc/bank.h" /home/jovyan/parametric-plasma-source/parametric_plasma_source/source_generator.cpp:4:10: fatal error: pugixml.hpp: No such file or directory 4 | #include "pugixml.hpp" | ^~~~~~~~~~~~~ The solution, could be replace: target_include_directories(source_generator PUBLIC ${OPENMC_DIR}/vendor/pugixml) to use openmc repo's target_include_directories(source_generator PUBLIC ${OPENMC_DIR}/vendor/pugixml/src) to use the git submodule target_include_directories(source_generator PUBLIC ${PROJECT_SOURCE_DIR}/pugixml/src) =========== 2) ========= I do not understand, why? because, I am on master branch, some cmake edit has not been merged? if(OpenMC_FOUND) # Build the source_sampling OpenMC plugin if OpenMC is available set(OPENMC_INC_DIR ${OpenMC_DIR}/../../../include/openmc) set(OPENMC_LIB_DIR ${OpenMC_DIR}/../../../lib) =========== 3) ============ the installation guide, said "make install" but python binary module should not install to "/usr/lib"? anyway, I have not yet get this step to test out — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#17>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AASTUSTNQKAIYXHEJV46VELSO76RLANCNFSM4TPOBFHQ>.

[qingfengxia]

Thank you, Hopefully Dan's new PR may fix it.