Skip to content

ChartView reads window.location.pathname directly instead of using router params #181

Description

@skearnes

Noted during review of #179 (review).

ChartView parses the dataset id out of window.location.pathname rather than receiving it as a prop from its parent (MainDatasetView), which already has the id via useParams(). The pathname read bypasses React Router entirely and quietly assumes the route shape stays /dataset/:datasetId.

Pass the dataset id down as a prop (or read it via useParams inside ChartView).

🤖 Generated with Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions