compat/new2old: Add CampaignIterateVariables#347
Merged
Conversation
The compat layer already adapted new-protocol benchmarks to the
legacy cartesian-product engine via the existing helper. The
iterate-style legacy campaign (where `variables` is an iterable of
records (one per run) rather than a `{name -> values}` cross-product)
had no compat path.
Add a sibling helper that accepts iterate-style records, aggregates
per-name distinct values across records, and reuses
`_check_fetch_args` to enforce that fetch parameters remain
single-valued (fetch runs once during bootstrap). It returns a
legacy `CampaignIterateVariablesOld`.
Mirror the LevelDB cartesian-helper test under iterate to exercise
the new path, with a deliberately sparse set of three records (not a
full cross-product) and a scatter plot.
Signed-off-by: Antonio Paolillo <apaolill@gmail.com>
Signed-off-by: Antonio Paolillo <apaolill@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compat layer already adapted new-protocol benchmarks to the legacy cartesian-product engine via the existing helper. The iterate-style legacy campaign (where
variablesis an iterable of records (one per run) rather than a{name -> values}cross-product) had no compat path.Add a sibling helper that accepts iterate-style records, aggregates per-name distinct values across records, and reuses
_check_fetch_argsto enforce that fetch parameters remain single-valued (fetch runs once during bootstrap). It returns a legacyCampaignIterateVariablesOld.Mirror the LevelDB cartesian-helper test under iterate to exercise the new path, with a deliberately sparse set of three records (not a full cross-product) and a scatter plot.