Skip to content

Refactor internal functions and add unit tests#59

Merged
ehennestad merged 17 commits into
mainfrom
refactor-internal-functions
Apr 14, 2025
Merged

Refactor internal functions and add unit tests#59
ehennestad merged 17 commits into
mainfrom
refactor-internal-functions

Conversation

@ehennestad
Copy link
Copy Markdown
Collaborator

@ehennestad ehennestad commented Apr 14, 2025

  • Deleted SchemaInspector class - Replaced by openminds.internal.meta.Type
  • Renamed openminds.internal.abstract.LinkedCategory to openminds.internal.abstract.MixedTypeSet
  • Moved some introspection methods from openminds.abstract.Schema to openminds.internal.meta.Type
  • Fixed some bugs in MetaTypeRegistry class that was recently added
  • Added unit tests for enumeration classes, openminds.internal.meta namespace and downloading a Github repo

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2025

Test Results (R2021b)

516 tests  +6   516 ✅ +6   1m 23s ⏱️ +23s
 13 suites +3     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit fa0770e. ± Comparison against base commit 04f07c8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2025

Test Results (R2024b)

516 tests  +6   516 ✅ +6   1m 21s ⏱️ +24s
 13 suites +3     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit fa0770e. ± Comparison against base commit 04f07c8.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 75.94937% with 19 lines in your changes missing coverage. Please review.

Project coverage is 73.35%. Comparing base (04f07c8) to head (fa0770e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
code/internal/+openminds/+internal/+meta/Type.m 62.50% 15 Missing ⚠️
...minds/+internal/+utility/+git/downloadRepository.m 70.00% 3 Missing ⚠️
...nternal/+meta/@MetaTypeRegistry/MetaTypeRegistry.m 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   65.30%   73.35%   +8.04%     
==========================================
  Files         323      320       -3     
  Lines        2678     2582      -96     
==========================================
+ Hits         1749     1894     +145     
+ Misses        929      688     -241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tools/tests/+ommtest/+internal/MetaTypeTest.m Fixed
@ehennestad ehennestad changed the title Refactor internal functions Refactor internal functions and add unit tests Apr 14, 2025
@ehennestad ehennestad marked this pull request as ready for review April 14, 2025 12:20
@ehennestad ehennestad merged commit fafe6e1 into main Apr 14, 2025
7 checks passed
@ehennestad ehennestad deleted the refactor-internal-functions branch April 14, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants