From 2dde4cea103e80e21af0302d7daf565c5f40d998 Mon Sep 17 00:00:00 2001 From: soriaoli Date: Mon, 30 Mar 2026 10:34:50 +0200 Subject: [PATCH] [locations] - Do not convert locations to lower case. --- .../evaluators/LocationsRestrictionsEvaluator.java | 2 +- .../evaluators/LocationsRestrictionsEvaluatorTest.java | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/opendevstack/component_catalog/server/services/restrictions/evaluators/LocationsRestrictionsEvaluator.java b/src/main/java/org/opendevstack/component_catalog/server/services/restrictions/evaluators/LocationsRestrictionsEvaluator.java index ee8b24a..39e5c57 100644 --- a/src/main/java/org/opendevstack/component_catalog/server/services/restrictions/evaluators/LocationsRestrictionsEvaluator.java +++ b/src/main/java/org/opendevstack/component_catalog/server/services/restrictions/evaluators/LocationsRestrictionsEvaluator.java @@ -73,7 +73,7 @@ private List> getAllParameterLocations(List list.stream() .map(CatalogItemUserActionParameterLocation::getLocation) - .map(String::toLowerCase).toList()) + .toList()) .toList(); } diff --git a/src/test/java/org/opendevstack/component_catalog/server/services/restrictions/evaluators/LocationsRestrictionsEvaluatorTest.java b/src/test/java/org/opendevstack/component_catalog/server/services/restrictions/evaluators/LocationsRestrictionsEvaluatorTest.java index a511c3f..b15ad09 100644 --- a/src/test/java/org/opendevstack/component_catalog/server/services/restrictions/evaluators/LocationsRestrictionsEvaluatorTest.java +++ b/src/test/java/org/opendevstack/component_catalog/server/services/restrictions/evaluators/LocationsRestrictionsEvaluatorTest.java @@ -135,7 +135,7 @@ void evaluateRestrictions_returnsFalse_whenNoCommonValuesAcrossLists() { } @Test - void evaluateRestrictions_convertsLocationsToLowerCase() { + void evaluateRestrictions_doNotConvertsLocationsToLowerCase() { //given var projectKey = "projectKey"; @@ -152,8 +152,8 @@ void evaluateRestrictions_convertsLocationsToLowerCase() { var result = evaluator.evaluate(evaluationRestrictions, params); //then - assertEquals(true, result.getLeft()); - assertEquals("", result.getRight()); + assertEquals(false, result.getLeft()); + assertEquals("This product is not provisionable in the project location.", result.getRight()); } @Test @@ -163,7 +163,7 @@ void evaluateRestrictions_returnsFalse_whenClustersAreNull() { var parameters = new ArrayList(); - List clusters = Collections.emptyList(); + List clusters = null; var restrictions = UserActionEntityRestrictionsMother.of(restrictionLoc); var params = RestrictionsParamsMother.of(parameters, clusters);