From d28394cd9fa383c0c57a18bbaff33348f8a30bed Mon Sep 17 00:00:00 2001 From: giswqs Date: Wed, 11 Nov 2026 00:04:04 -0500 Subject: [PATCH] Address Claude review feedback - A raster completion (`ran`) refused because its extension is off lets go of its pending raster, as finish_raster does. - The Workflows pane ends the map pick of a section it closes because its extension went off; a pick started with no section open stays. --- crates/engine/src/policy/dispatch.rs | 4 ++++ crates/ui-egui/src/analysispane.rs | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/crates/engine/src/policy/dispatch.rs b/crates/engine/src/policy/dispatch.rs index c6e0f2e5e3..20c2747343 100644 --- a/crates/engine/src/policy/dispatch.rs +++ b/crates/engine/src/policy/dispatch.rs @@ -693,6 +693,10 @@ impl Session { // command of an extension that is off, as `Session::run` does: the one asked for, and // the one a completion finishes. if let Some(why) = self.extensions().blocks(id) { + // A completion's raster is let go, as `finish_raster` does. + if let Some(run) = params.get("ran").and_then(Value::as_u64) { + self.raster_results.retain(|(n, _)| *n != run); + } return Err(why); } let op = self.authorize_unchecked(id, params)?; diff --git a/crates/ui-egui/src/analysispane.rs b/crates/ui-egui/src/analysispane.rs index 9a94af648c..5ed6df5fc7 100644 --- a/crates/ui-egui/src/analysispane.rs +++ b/crates/ui-egui/src/analysispane.rs @@ -476,6 +476,10 @@ fn picked(app: &mut RustGisApp, purpose: &str) -> Option