From 4591b269838cbdb37a351c5170b4e5d492c30f03 Mon Sep 17 00:00:00 2001 From: giswqs Date: Wed, 11 Nov 2026 06:53:26 -0500 Subject: [PATCH] test(ui): wait for a flat map's off-thread settled frame in the GPU test settling_after_a_camera_animation_re_renders_fully read the full frame's camera five UI steps after the animation ended. Since #1775 a flat, north-up map's settled frame is drawn off the UI thread, so it had not arrived yet and the test saw the previous frame's camera. The test fails on the macOS and Windows runners, which have a GPU adapter; the Linux runners skip it. Wait for the frame with the file's wait_for_frame, as the other tests there do. --- crates/ui-egui/tests/gpu_fastpath.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/crates/ui-egui/tests/gpu_fastpath.rs b/crates/ui-egui/tests/gpu_fastpath.rs index 4f9df7ac34..a26249c37a 100644 --- a/crates/ui-egui/tests/gpu_fastpath.rs +++ b/crates/ui-egui/tests/gpu_fastpath.rs @@ -107,9 +107,8 @@ fn settling_after_a_camera_animation_re_renders_fully() { } } assert!(settled, "the animation finished"); - for _ in 0..5 { - h.step(); - } + // A flat map's settled frame is drawn off the UI thread (#1750): wait for it to arrive. + wait_for_frame(&mut h); let app = h.state(); let (cam, tex_cam) = (app.session.map().camera, app.map.full_frame_camera()); assert_eq!((tex_cam.center, tex_cam.res), (cam.center, cam.res), "a full re-render followed the settled camera (tex_camera refreshed)");