From 76009a3828a5353e20761458f72927da1d74c20a Mon Sep 17 00:00:00 2001 From: giswqs Date: Mon, 16 Nov 2026 23:48:31 -0500 Subject: [PATCH 1/2] test(geolibre): mark the langpack removal-blocking sleep as a test wait The removal test added in #2289 sleeps to show remove() stays blocked while a check holds LIFECYCLE. test-hygiene requires a // test-wait: reason on timer waits, so CI failed on main on every platform. --- crates/geolibre/src/langpack.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/geolibre/src/langpack.rs b/crates/geolibre/src/langpack.rs index 4951ba850..d255104c4 100644 --- a/crates/geolibre/src/langpack.rs +++ b/crates/geolibre/src/langpack.rs @@ -732,7 +732,7 @@ mod tests { // record an error for a pack already gone. let check = LIFECYCLE.lock().unwrap(); let removal = std::thread::spawn(|| remove("fr")); - std::thread::sleep(std::time::Duration::from_millis(200)); + std::thread::sleep(std::time::Duration::from_millis(200)); // test-wait: proves remove() stays blocked while a check holds LIFECYCLE; no signal marks a blocked call assert!(!removal.is_finished(), "remove ran during a check"); drop(check); removal.join().unwrap().unwrap(); From eec18bb2ef92332238f464ed06eb49b37f7e40ef Mon Sep 17 00:00:00 2001 From: giswqs Date: Mon, 16 Nov 2026 23:49:16 -0500 Subject: [PATCH 2/2] ci: run test-hygiene on the whole workspace on every pull request The test job runs only the packages a pull request changes, so xtask's hygiene test missed the new sleep in #2289 and main failed. --- .github/workflows/ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ac5034dda..2a3e0e1e8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -193,6 +193,11 @@ jobs: # to the schema alone is checked against them too. - name: Validate the fixture projects against the schema run: pipx run check-jsonschema==0.39.0 --schemafile schema/project.schema.json --default-filetype json schema/fixtures/*.rgis + # Timer waits and ignored tests carry their reasons. xtask's own test checks this too, but + # `test` runs only the packages a pull request changes, so a new wait elsewhere got past it + # and failed main (#2289). This runs on the whole workspace every time. + - name: Test hygiene + run: cargo run --locked -q -p xtask -- test-hygiene # The packages whose tests this run needs, for `test` (.github/scripts/test-selection.sh). Only # tests are narrowed: lint, the wasm build, licences and the schema check run whole every time.