chore: revert hiding of number field stepper buttons#9568
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts a prior frontend UX change that hid the increment/decrement steppers on the public Number field input, restoring the default stepper controls on NumberInput for number fields.
Changes:
- Removes
showSteppers={false}from the Number field template so steppers are shown again. - Deletes the unit test that asserted the steppers were not rendered.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/frontend/src/templates/Field/Number/NumberField.tsx | Restores default NumberInput stepper rendering by removing showSteppers={false}. |
| apps/frontend/src/templates/Field/Number/NumberField.test.tsx | Removes the stepper-hidden assertion test. |
Comment on lines
36
to
38
| <NumberInput | ||
| showSteppers={false} | ||
| min={0} | ||
| inputMode="numeric" |
Comment on lines
15
to
16
| describe('validation required', () => { | ||
| it('does not render stepper buttons', () => { | ||
| render(<ValidationRequired />) | ||
| expect( | ||
| screen.queryByRole('button', { name: /increment/i, hidden: true }), | ||
| ).toBeNull() | ||
| expect( | ||
| screen.queryByRole('button', { name: /decrement/i, hidden: true }), | ||
| ).toBeNull() | ||
| }) | ||
|
|
||
| it('renders error when field is not filled before submitting', async () => { |
eliotlim
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A previous change removed the stepper (increment/decrement) buttons from the Number field by setting
showSteppers={false}. This change should be reverted — the stepper buttons provide useful UX for number inputs and should remain visible.Solution
Reverts the
showSteppers={false}prop on theNumberInputcomponent inNumberField.tsx, restoring the default stepper button behaviour. The corresponding test that asserted the buttons were hidden has also been removed.Breaking Changes
Before & After Screenshots
Tests
TC1: Stepper buttons visible on Number field