Skip to content

chore: revert hiding of number field stepper buttons #9568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eliotlim merged 1 commit into from
Jun 9, 2026
+0 −11
Merged

chore: revert hiding of number field stepper buttons #9568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions apps/frontend/src/templates/Field/Number/NumberField.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,6 @@ import * as stories from './NumberField.stories'
const { ValidationRequired, ValidationOptional } = composeStories(stories)

describe('validation required', () => {
it('does not render stepper buttons', () => {
render(<ValidationRequired />)
expect(
screen.queryByRole('button', { name: /increment/i, hidden: true }),
).toBeNull()
expect(
screen.queryByRole('button', { name: /decrement/i, hidden: true }),
).toBeNull()
})

it('renders error when field is not filled before submitting', async () => {
Comment on lines 15 to 16
// Arrange
const user = userEvent.setup()
Expand Down
1 change: 0 additions & 1 deletion apps/frontend/src/templates/Field/Number/NumberField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ export const NumberField = ({
defaultValue=""
render={({ field: { value, onChange, ...rest } }) => (
<NumberInput
showSteppers={false}
min={0}
inputMode="numeric"
Comment on lines 36 to 38
colorScheme={`theme-${colorTheme}`}
Expand Down
Loading