Skip to content

[SES-PHASE-1-7] - PLU-744: add env vars for ses and sqs#1633

Open
m0nggh wants to merge 1 commit into
feat/ses/add-admin-whitelistingfrom
feat/ses/add-env-vars
Open

[SES-PHASE-1-7] - PLU-744: add env vars for ses and sqs#1633
m0nggh wants to merge 1 commit into
feat/ses/add-admin-whitelistingfrom
feat/ses/add-env-vars

Conversation

@m0nggh

@m0nggh m0nggh commented May 19, 2026

Copy link
Copy Markdown
Contributor

TL;DR

Adds SES and SQS environment variable references to the ECS configuration.

What changed?

Three new environment variable entries have been added to the ECS environment configuration:

  • SES_ROLE_ARN — sourced from plumber-ses-role-arn
  • SES_CONFIGURATION_SET — sourced from plumber-<ENVIRONMENT>-ses-configuration-set
  • SQS_QUEUE_URL — sourced from plumber-<ENVIRONMENT>-sqs-queue-url

A missing newline at the end of the file has also been added.

How to test?

Note: Tested on UAT

Deploy to a non-production environment and verify that the SES and SQS environment variables are correctly injected into the running ECS task. Confirm the values resolve properly from their respective secrets/parameter store entries.

Why make this change?

These environment variables are required to support SES email sending (via an assumed IAM role and configuration set) and SQS queue integration within the ECS-hosted service.

@m0nggh m0nggh force-pushed the feat/ses/add-admin-whitelisting branch from 9c04394 to d5647a6 Compare May 19, 2026 09:22
@m0nggh m0nggh force-pushed the feat/ses/add-env-vars branch 2 times, most recently from 35706ff to 3db2cbc Compare May 19, 2026 09:50
@m0nggh m0nggh force-pushed the feat/ses/add-admin-whitelisting branch from d5647a6 to 19d6d37 Compare May 19, 2026 09:50
@datadog-opengovsg

This comment has been minimized.

@m0nggh m0nggh force-pushed the feat/ses/add-admin-whitelisting branch from 19d6d37 to e533f62 Compare May 19, 2026 23:23
@m0nggh m0nggh force-pushed the feat/ses/add-env-vars branch from 3db2cbc to d24c3a0 Compare May 19, 2026 23:23
@m0nggh m0nggh changed the title add env vars for ses and sqs [SES-PHASE-1-7] - PLU-744: add env vars for ses and sqs May 20, 2026
@linear

linear Bot commented May 20, 2026

Copy link
Copy Markdown

PLU-744

@ogp-weeloong ogp-weeloong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try to roles etc in in our Iac repo as well

@m0nggh m0nggh force-pushed the feat/ses/add-admin-whitelisting branch from e533f62 to badc3fe Compare May 22, 2026 11:16
@m0nggh m0nggh force-pushed the feat/ses/add-env-vars branch from d24c3a0 to a60b320 Compare May 22, 2026 11:16

@ogp-weeloong ogp-weeloong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@m0nggh m0nggh force-pushed the feat/ses/add-admin-whitelisting branch from badc3fe to a291c21 Compare June 8, 2026 09:03
@m0nggh m0nggh force-pushed the feat/ses/add-env-vars branch 2 times, most recently from 9a41983 to ff1bad2 Compare June 8, 2026 11:01
@m0nggh m0nggh force-pushed the feat/ses/add-admin-whitelisting branch 2 times, most recently from 983424e to 68d56fe Compare June 8, 2026 12:02
@m0nggh m0nggh force-pushed the feat/ses/add-env-vars branch from ff1bad2 to a32f27a Compare June 8, 2026 12:02
@m0nggh m0nggh force-pushed the feat/ses/add-env-vars branch 2 times, most recently from f020b93 to 69fb6dc Compare June 8, 2026 15:02
@m0nggh m0nggh force-pushed the feat/ses/add-admin-whitelisting branch 2 times, most recently from 067c7be to 8dbd477 Compare June 8, 2026 15:03
@m0nggh m0nggh force-pushed the feat/ses/add-env-vars branch 2 times, most recently from 46fc7be to 4d4108d Compare June 8, 2026 16:00
@m0nggh m0nggh force-pushed the feat/ses/add-admin-whitelisting branch from 8dbd477 to 1d0d495 Compare June 8, 2026 16:00
@m0nggh m0nggh force-pushed the feat/ses/add-env-vars branch from 4d4108d to 921f21a Compare June 8, 2026 16:02
@m0nggh m0nggh force-pushed the feat/ses/add-admin-whitelisting branch from 6b9d2e4 to 08ba295 Compare June 8, 2026 16:48
@m0nggh m0nggh force-pushed the feat/ses/add-env-vars branch from 921f21a to aab629b Compare June 8, 2026 16:48
@m0nggh m0nggh force-pushed the feat/ses/add-admin-whitelisting branch from 08ba295 to 87b8040 Compare June 8, 2026 16:50
@m0nggh m0nggh force-pushed the feat/ses/add-env-vars branch from aab629b to 97d3b6f Compare June 8, 2026 16:50
@m0nggh m0nggh force-pushed the feat/ses/add-admin-whitelisting branch from 87b8040 to a16af3c Compare June 8, 2026 16:57
@m0nggh m0nggh force-pushed the feat/ses/add-env-vars branch from 97d3b6f to 555afa8 Compare June 8, 2026 16:57
@m0nggh m0nggh force-pushed the feat/ses/add-env-vars branch from 555afa8 to 0ab31fe Compare June 9, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants