Provide source for commands sent to openHAB

[ccutrer]

See openhab/openhab-core#5041 and docs at https://next.openhab.org/docs/developer/utils/events.html#the-core-events

Basically just add &source=org.openhab.android to the query string (or regenerate the openapi wrapper after that PR is merged, if you use that). If you can think of something useful for the "actor" (username or device name), append that after a $.

[mueller-ma]

If you can think of something useful for the "actor"

The app has a setting called "device identifier" which is a user-chosen string to identify which device send a voice command or scanned a nfc tag. It can be re-used for this purpose as well.

[ccutrer]

Perfect!

[ccutrer]

The source query parameter PR merged a few hours ago for both core and openhabcloud. So this should now be testable. Passing it as a header has not yet been implemented.

[ccutrer]

The header source PR is pending, as is BasicUI source PR. I have not yet written one for MainUI, but when I do I'll use the same header, and then when you intercept the web request you should add org.openhab.android$<device identifier>> to the front of the header value. For the latter, since the mobile app constructs the request completely, you should construct it like org.openhab.android<device identifier>>org.openhab.ui.basic$<sitemap>:<page> so it looks the same as if it was in a browser.

EDIT: MainUI PR

[maniac103]

you should construct it like org.openhab.android>org.openhab.ui.basic$: so it looks the same as if it was in a browser.

Why should we pretend that it was BasicUI that executed it and we just forwarded it? I'd rather format it as org.openhab.android[<device identifier>]$<sitemap>:<page>.

[maniac103]

Also, should <sitemap> be the sitemap name (e.g. uicomponents_page_d30f131f4c) or the label (e.g. My Sitemap)?

Edit: looks like sitemap name, judging from Basic UI code.

[maniac103]

The commit above implements sending the source ID. Will make a PR once #3963 is in since the source ID commit depends on changes made there.