Email Subjects on Template

[ajrbyers]

Describe the bug
Currently the email subject value displayed is hard coded on the template.

Janeway version
1.4.1

Expected behavior
The email subject for the template being sent should be displayed.

Additional
We should check that all email subjects conform to the pattern: subject_name_of_related_template this can be achieved by a test and will also identify any that do not conform.

[ajrbyers]

• In typesetting some emails (emails.py) do not pull a setting from the database.
• The APC plugin has no email subjects

[ajrbyers]

See PRs on Typesetting and APC:

• #16 adds email subjects to the APC plugin apc#22
• #3043 transactional emails now use appropriate subject settings. typesetting#167

[joemull]

@ajrbyers In addition to the PRs on apc and typesetting, does the fix for this involve https://github.com/BirkbeckCTP/janeway/compare/3043-email_subjects ? Ready for a PR?

[ajrbyers]

Mmm we agreed this wouldn’t go forward as @mauromsl was making changes to these templates.

[joemull]

Mmm we agreed this wouldn’t go forward as @mauromsl was making changes to these templates.

OK, then is there anything that I can do on this issue @ajrbyers @mauromsl ? I set the status to in progress.