[ANC Rwanda/Zambia] Proceeding with the Client whose previous contacts were done by different user has some issues.

[Naima-Bashir]

Affected App or Server Version

Latest apk

What kind of support do you need?

When the user tries to create contact 2 of the client whose information was fed by another user, it becomes difficult as it is not possible to view the Client's profile and previously fed information by a different user.

The issues are as follows when you try to work with information fed by other users.

1. When you click to see the profile, the app crashes.
2. When you click to start specific contact, previous fed data does not appear as it is expected

Original ticket can be found here: [(https://github.com/opensrp/opensrp-client-core/issues/924)]

What is the acceptance criteria for your support request?

App should not crash when one tries to access clients created by other users.
The previous data from contacts should be visible.

Relevant Information

No response

[Naima-Bashir]

A. The ANR and the app crashes has been fixed in this apk. The latest PR can be found here.

B. As for the empty previous contacts data; Ona has requested 1000 Hills verify the following:

1. Is the application syncing properly? (all events ie patients, previous contact data etc)
2. Is the previous contacts' data available on the previous contacts table in the sqlite db?
3. If yes, is the data available on the facts map?

Confirming that the data is available in the sqlite database tagged with corresponding contact number(s) will mean the issue arises when the application is displaying the data.

[Naima-Bashir]

1000 Hills have verified that the data is on the database.

[Naima-Bashir]

Displaying of data is the issue. The next step is to check which sections are failing to display the data. We can check which Interactors and activities call the following methods: cc @hilpitome

1. getPreviousContactsFacts
2. getPreviousContactTestsFacts
3. getAllTests

[Naima-Bashir]

The interactors and activities that call the methods are:

1. getPreviousContactFacts

• ProfileContactsfragment
• PreviousContactsTestsActivity

2. getPreviousContactsTests
-PreviousContactsTestsActivity

3. =>getAllTests is called within this method

[Naima-Bashir]

Updates:

• Upon reviewing the code to identify the sections where data is failing to display, we noticed that the previous contact details from the database are empty. Further investigation of the actual SQLite database revealed that there is less data than expected (attached screenshot). Based on this information, we suspect that this issue may be caused by a sync failure.
• We are currently investigating the sync failure, but we have encountered a blocker in the Tests Page. Each time we input data into the Tests Page, it gets cleared, making it impossible for us to finalize the contact form and subsequently test the Previous Contact data issue.
  

[Naima-Bashir]

Updates on the bug:
The previous contact bug has 2 sides: Ona has solved problem 1 and is currently working on 2:

1. Data in the previous_contact table not showing up on the screen
2. Data synced from another device not showing up in the previous_contact table

[Naima-Bashir]

23/02/2024 Updates:

1. We identified and resolved an issue where the 'get previous contact facts' function ran recursively into infinity due to the contact number not being decremented. The changes can be reviewed here.
2. Additionally, we addressed a problem where previous contacts were not displaying because of a negative sign appended to the contact number. We have fixed this by removing the negative sign to ensure the query retrieves the correct contact number. You can find the related changes here.
3. We then fixed a 'NullPointerException' that occurred when creating a contact visit event. This event is used to generate previous contact records after syncing on other devices. This issue resulted in missing previous contacts when logging in with another user or device. You can review the changes made here.
4. Lastly, we have optimized the performance and responsiveness of the application by moving the code responsible for retrieving previous contacts into a background thread. The relevant changes can be found here.

[Naima-Bashir]

This has been resolved and confirmed by 1000 Hills solutions. Closing this cc @hilpitome