Yamllint

.github/workflows/yamllint-core.yml

@@ -0,0 +1,33 @@
+name: yamllint
+
+on:
+  pull_request:
+    paths:
+      - '.yamllint.yml'
+      - 'config/locales/en.yml'
+      - 'config/locales/js-en.yml'
+      - 'modules/*/config/locales/en.yml'
+      - 'modules/*/config/locales/js-en.yml'
+
+permissions: {}
+
+jobs:
+  rubocop:
+    name: yamllint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        with:
+          persist-credentials: false
+
+      - name: Run Yamllint
+        uses: reviewdog/action-yamllint@f01d8a48fd8d89f89895499fca2cff09f9e9e8c0 # v1.21.0
+        with:
+          github_token: ${{ secrets.github_token }}
+          yamllint_flags: >
+            .yamllint.yml
+            config/locales/en.yml
+            config/locales/js-en.yml
+            modules/*/config/locales/en.yml
+            modules/*/config/locales/js-en.yml

.yamllint.yml

@@ -0,0 +1,8 @@
+---
+extends: default
+
+rules:
+  comments:
+    require-starting-space: false
+  key-ordering: {}
+  line-length: disable

config/locales/en.yml

@@ -26,6 +26,7 @@
 # See COPYRIGHT and LICENSE files for more details.
 #++
 
+---
 en:
   no_results_title_text: There is currently nothing to display.
 
@@ -1822,7 +1823,7 @@ en:
       changeset:
         repository: "Repository"
       comment:
-        commented: "Commented" # an object that this comment belongs to
+        commented: "Commented"  # an object that this comment belongs to
       custom_action:
         actions: "Actions"
       custom_field:
@@ -2116,7 +2117,7 @@ en:
         redirect_existing_links: "Redirect existing links"
         text: "Page content"
       work_package:
-        ancestor: "Descendants of" # used for filtering of work packages that are descendants of a given work package
+        ancestor: "Descendants of"  # used for filtering of work packages that are descendants of a given work package
         begin_insertion: "Begin of the insertion"
         begin_deletion: "Begin of the deletion"
         children: "Subelements"
@@ -2134,7 +2135,7 @@ en:
           false: "working days only"
           true: "include non-working days"
         journal_internal: Internal Journal
-        notify: "Notify" # used in custom actions
+        notify: "Notify"  # used in custom actions
         parent: "Parent"
         parent_issue: "Parent"
         parent_work_package: "Parent"
@@ -4848,9 +4849,9 @@ en:
       A new user (%{email}) tried to create an account on an OpenProject environment that you manage (%{host}).
       The user cannot activate their account since the user limit has been reached.
     steps:
+      a: "Upgrade your payment plan ([here](upgrade_url))"  # here turned into a link
+      b: "Lock or delete an existing user ([here](users_url))"  # here turned into a link
       label: "To allow the user to sign in you can either: "
-      a: "Upgrade your payment plan ([here](upgrade_url))" # here turned into a link
-      b: "Lock or delete an existing user ([here](users_url))" # here turned into a link
 
   more_actions: "More functions"
 

config/locales/js-en.yml

@@ -26,6 +26,7 @@
 # See COPYRIGHT and LICENSE files for more details.
 #++
 
+---
 en:
   js:
     ajax:

crowdin.yml

@@ -20,15 +20,15 @@ files: [
     "translation": "/config/locales/crowdin/%two_letters_code%.seeders.yml"
   },
   {
-    "source": "/modules/**/config/locales/en.yml",
-    "translation": "/modules/**/config/locales/crowdin/%two_letters_code%.yml"
+    "source": "/modules/*/config/locales/en.yml",
+    "translation": "/modules/*/config/locales/crowdin/%two_letters_code%.yml"
   },
   {
-    "source": "/modules/**/config/locales/js-en.yml",
-    "translation": "/modules/**/config/locales/crowdin/js-%two_letters_code%.yml"
+    "source": "/modules/*/config/locales/js-en.yml",
+    "translation": "/modules/*/config/locales/crowdin/js-%two_letters_code%.yml"
   },
   {
-    "source": "/modules/**/config/locales/en.seeders.yml",
-    "translation": "/modules/**/config/locales/crowdin/%two_letters_code%.seeders.yml"
+    "source": "/modules/*/config/locales/en.seeders.yml",
+    "translation": "/modules/*/config/locales/crowdin/%two_letters_code%.seeders.yml"
   },
 ]

modules/auth_saml/config/locales/en.yml

@@ -1,3 +1,4 @@
+---
 en:
   activerecord:
     attributes:

modules/avatars/config/locales/en.yml

@@ -1,4 +1,5 @@
 # English strings go here
+---
 en:
   plugin_openproject_avatars:
     name: "Avatars"
@@ -14,8 +15,8 @@
   error_image_upload: "Error saving the image."
   error_image_size: "The image is too large."
   are_you_sure_delete_avatar: "Are you sure you want to delete your avatar?"
-  avatar_deleted:  "Avatar deleted successfully."
-  unable_to_delete_avatar:  "Avatar could not be deleted."
+  avatar_deleted: "Avatar deleted successfully."
+  unable_to_delete_avatar: "Avatar could not be deleted."
   wrong_file_format: "Allowed formats are jpg, png, gif"
   empty_file_error: "Please upload a valid image (jpg, png, gif)"
 

modules/avatars/config/locales/js-en.yml

@@ -1,4 +1,5 @@
 # English strings go here
+---
 en:
   js:
     label_preview: 'Preview'
@@ -13,4 +14,3 @@ en:
       error_image_too_large: "Image is too large."
       wrong_file_format: "Allowed formats are jpg, png, gif"
       empty_file_error: "Please upload a valid image (jpg, png, gif)"
-

modules/backlogs/config/locales/js-en.yml

@@ -26,6 +26,7 @@
 # See COPYRIGHT and LICENSE files for more details.
 #++
 
+---
 en:
   js:
     work_packages:

modules/bim/config/locales/en.yml

@@ -1,4 +1,5 @@
 # English strings go here for Rails i18n
+---
 en:
   plugin_openproject_bim:
     name: "OpenProject BIM and BCF functionality"

modules/bim/config/locales/js-en.yml

@@ -1,4 +1,5 @@
 # English strings go here
+---
 en:
   js:
     bcf:

modules/boards/config/locales/en.yml

@@ -1,4 +1,5 @@
 # English strings go here
+---
 en:
   plugin_openproject_boards:
     name: "OpenProject Boards"

modules/boards/config/locales/js-en.yml

@@ -1,4 +1,5 @@
 # English strings go here
+---
 en:
   ee:
     upsell:
@@ -50,7 +51,7 @@ en:
           Board with automated columns for subprojects.
           Dragging work packages to other lists updates the (sub-)project accordingly.
         action_text_subtasks: >
-          Board with automated columns for sub-elements. 
+          Board with automated columns for sub-elements.
           Dragging work packages to other lists updates the parent accordingly.
         action_text_status: >
           Basic kanban style board with columns for status such as To Do, In Progress, Done.

modules/budgets/config/locales/js-en.yml

@@ -26,6 +26,7 @@
 # See COPYRIGHT and LICENSE files for more details.
 #++
 
+---
 en:
   js:
     work_packages:

modules/calendar/config/locales/en.yml

@@ -1,4 +1,5 @@
 # English strings go here
+---
 en:
   plugin_openproject_calendar:
     name: "OpenProject Calendar"

modules/calendar/config/locales/js-en.yml

@@ -1,4 +1,5 @@
 # English strings go here
+---
 en:
   js:
     calendar:

modules/costs/config/locales/js-en.yml

@@ -26,6 +26,7 @@
 # See COPYRIGHT and LICENSE files for more details.
 #++
 
+---
 en:
   js:
     text_are_you_sure: "Are you sure?"

modules/documents/config/locales/en.yml

@@ -26,6 +26,7 @@
 # See COPYRIGHT and LICENSE files for more details.
 #++
 
+---
 en:
   plugin_openproject_documents:
     name: "OpenProject Documents"

modules/gantt/config/locales/en.yml

@@ -1,3 +1,4 @@
 # English strings go here
+---
 en:
   project_module_gantt: "Gantt charts"

modules/gantt/config/locales/js-en.yml

@@ -1,3 +1,4 @@
+---
 en:
   js:
     work_packages:

modules/github_integration/config/locales/en.yml

@@ -26,6 +26,7 @@
 # See COPYRIGHT and LICENSE files for more details.
 #++
 
+---
 en:
   attributes:
     additions_count: "Number of additions"

modules/github_integration/config/locales/js-en.yml

@@ -26,6 +26,7 @@
 # See COPYRIGHT and LICENSE files for more details.
 #++
 
+---
 en:
   js:
     github_integration:

modules/gitlab_integration/config/locales/en.yml

@@ -27,6 +27,7 @@
 # See docs/COPYRIGHT.rdoc for more details.
 #++
 
+---
 en:
   attributes:
     commit: "Commit"

modules/gitlab_integration/config/locales/js-en.yml

@@ -27,6 +27,7 @@
 # See docs/COPYRIGHT.rdoc for more details.
 #++
 
+---
 en:
   js:
     gitlab_integration:

modules/grids/config/locales/en.yml

@@ -1,3 +1,4 @@
+---
 en:
   grids:
     label_widget_in_grid: "Widget contained in Grid %{grid_name}"

modules/grids/config/locales/js-en.yml

@@ -1,3 +1,4 @@
+---
 en:
   js:
     grid:

modules/job_status/config/locales/en.yml

@@ -1,3 +1,4 @@
+---
 en:
   label_job_status_plural: "Job statuses"
   plugin_openproject_job_status:

modules/ldap_groups/config/locales/en.yml

@@ -1,3 +1,4 @@
+---
 en:
   ee:
     upsell:

modules/meeting/config/locales/en.yml

@@ -27,6 +27,7 @@
 #++
 
 # English strings go here for Rails i18n
+---
 en:
   plugin_openproject_meeting:
     name: "OpenProject Meeting"

modules/meeting/config/locales/js-en.yml

@@ -26,6 +26,7 @@
 # See COPYRIGHT and LICENSE files for more details.
 #++
 
+---
 en:
   js:
     label_meetings: 'Meetings'

modules/my_page/config/locales/en.yml

@@ -1,3 +1,4 @@
+---
 en:
   my_page:
     label: "My page"

modules/openid_connect/config/locales/en.yml

@@ -1,3 +1,4 @@
+---
 en:
   plugin_openproject_openid_connect:
     name: "OpenProject OpenID Connect"

modules/overviews/config/locales/en.yml

@@ -1,3 +1,4 @@
+---
 en:
   overviews:
     label_home: "%{workspace_type} home"

modules/overviews/config/locales/js-en.yml

@@ -1,3 +1,4 @@
+---
 en:
   js:
     overviews:

modules/recaptcha/config/locales/en.yml

@@ -1,4 +1,5 @@
 # English strings go here for Rails i18n
+---
 en:
   plugin_openproject_recaptcha:
     name: "OpenProject ReCaptcha"

modules/reporting/config/locales/js-en.yml

@@ -25,6 +25,7 @@
 #
 # See COPYRIGHT and LICENSE files for more details.
 #++
+---
 en:
   js:
     reporting_engine:

modules/resource_management/config/locales/en.yml

@@ -1,3 +1,4 @@
+---
 en:
   activerecord:
     attributes:
@@ -51,7 +52,7 @@
     a planner and adjusting the allocated time and date range.
 
   label_resource_management: "Resource planning"
-  button_next: "Save" # TODO: This should be "Next" but we need to check the flow first
+  button_next: "Save"  # TODO: This should be "Next" but we need to check the flow first
 
   resource_management:
     label_resource_planner: "Resource planner"

modules/storages/config/locales/js-en.yml

@@ -1,4 +1,5 @@
 # English strings go here
+---
 en:
   js:
     storages:

modules/team_planner/config/locales/en.yml

@@ -1,4 +1,5 @@
 # English strings go here
+---
 en:
   plugin_openproject_team_planner:
     name: "OpenProject Team Planner"

modules/team_planner/config/locales/js-en.yml

@@ -1,4 +1,5 @@
 # English strings go here
+---
 en:
   js:
     team_planner:
@@ -19,7 +20,7 @@
       today: 'Today'
       drag_here_to_remove: 'Drag here to remove assignee and start and end dates.'
       cannot_drag_here: 'Cannot move the work package due to permissions or editing restrictions.'
-      cannot_drag_to_non_working_day : 'This work package cannot start/finish on a non-working day.'
+      cannot_drag_to_non_working_day: 'This work package cannot start/finish on a non-working day.'
 
       quick_add:
         empty_state: 'Use the search field to find work packages and drag them to the planner to assign it to someone and define start and end dates.'

modules/two_factor_authentication/config/locales/en.yml

@@ -1,4 +1,5 @@
 # English strings go here for Rails i18n
+---
 en:
   plugin_openproject_two_factor_authentication:
     name: "OpenProject Two-factor authentication"

modules/two_factor_authentication/config/locales/js-en.yml

@@ -25,6 +25,7 @@
 #
 # See COPYRIGHT and LICENSE files for more details.
 #++
+---
 en:
   js:
     two_factor_authentication: