Allow checkpoints to skip git commit hooks #152
Closed
f-moya
started this conversation in
Feature Requests
Replies: 3 comments 1 reply
|
Hi @f-moya -- Thanks for this proposal. This seems reasonable to me! I'll try to add it to the next release. |
0 replies
|
@brynary did this get in? I suspect not because I'm having issues with pre-commit hooks impacting checkpoints on 0.227.0 . |
1 reply
|
This is landed in main and will be making its way to releases soon: http://127.0.0.1:32276/runs/01KSA36AH4GPG3D8P1EP0HBG7X |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Hi Bryan! Just started testing Fabro and really liking it so far.
I noticed that checkpoint commits run all git hooks since the commit command doesn't pass
--no-verify. In my case thiscauses some slowdowns because I have pre-commit hooks set up in the repo (linters, formatters, etc.), and they fire on
every checkpoint even though those commits are internal bookkeeping on run branches.
Would it be possible to add something like a
skip_hooksoption to the checkpoint config? Something like:That way users with heavier hook setups can opt out for checkpoints without having to modify their hooks. Thanks!
-- Update
It seems like
skip_hooksmight not be good naming as it conflicts a bit with https://docs.fabro.sh/agents/hooks#hooksAll reactions